GCP-375: add GCP PD CSI driver implementation and migration plans #5
Conversation
|
@ckandag: This pull request references GCP-375 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the spike to target the "4.22.0" version, but no target version was set. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ckandag The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
WalkthroughTwo implementation planning documents added: one describing a two-stage migration of gcp-pd-csi-driver-operator into the csi-operator repository; the other detailing end-to-end implementation for enabling the GCP Persistent Disk CSI driver on GCP Hosted Control Planes, including assets, integrations, and testing. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
Add two implementation plan documents for enabling GCP Persistent Disk CSI driver support on GCP Hosted Control Planes: - gcp-persistent-disk-csi-driver.md: High-level plan covering component flow, credential architecture (WIF), CR dependencies, and work areas across HyperShift Operator, CPO, HCCO, and csi-operator. - gcp-pd-csi-operator-migration.md: Detailed migration plan for moving gcp-pd-csi-driver-operator into the csi-operator monorepo, covering Stage 1 (blind copy), Stage 2 (HyperShift integration), asset generation, deployment hooks, and CI/build pipeline updates. Signed-off-by: Chaitanya Kandagatla <ckandaga@redhat.com> Assisted-by: Cursor (cursor.com)
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 5
🤖 Fix all issues with AI agents
In `@implementation-plans/gcp-pd-csi-operator-migration.md`:
- Around line 303-305: The phrase "merge together" in the "### 2.11 Merge
Coordination" paragraph is wordy; change the sentence "Both openshift/release
and ocp-build-data PRs must merge together (robot sync dependency)." to "Both
openshift/release and ocp-build-data PRs must merge (robot sync dependency)."
Update the text in the "Merge Coordination" section to use "merge" instead of
"merge together".
- Around line 125-139: The fenced code block in
implementation-plans/gcp-pd-csi-operator-migration.md that shows the
assets/overlays/gcp-pd/ tree is missing a language identifier; update the
opening triple-backtick to include a language such as "text" or "bash" (e.g.,
change ``` to ```text) so markdownlint rule MD040 is satisfied; no other content
changes required—just add the language token for that specific code block.
In `@implementation-plans/gcp-persistent-disk-csi-driver.md`:
- Line 1: Update the document title "# GCP Persistent Disk CSI Driver for GCP
Hosted Control Planes" to use correct hyphenation when the phrase is adjectival;
change it to "# GCP Persistent Disk CSI Driver for GCP Hosted-Control-Planes"
(or rephrase to "Hosted control planes" if not adjectival) so the title follows
the suggested hyphenation; locate the exact title string in the file and replace
it accordingly.
- Around line 55-75: The fenced diagram blocks (containing symbols like
HostedCluster, HostedControlPlane, ClusterCSIDriver CR, StorageClass, and
gcp-pd-cloud-credentials) are missing language identifiers and trigger MD040;
update each triple-backtick block to include an explicit language token (for
example `text`, `plain`, or `diff`) so markdownlint passes, and apply the same
change to the other fenced block referenced (the block shown around lines with
the same diagram later in the document).
- Around line 129-142: Replace the wordy phrase "merge together" with the
concise "merge" in the plan table entries that currently read "Merge
coordination" rows (e.g., the rows labeled "1.5 | Merge coordination" and "2.11
| Merge coordination") so the description cells read "Both PRs must merge" or
"Both openshift/release and ocp-build-data PRs must merge" respectively; update
any other occurrences of the exact phrase "merge together" to "merge" to satisfy
the linter.
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@implementation-plans/gcp-pd-csi-operator-migration.md`:
- Line 11: Replace the word "bugfixes" with "bug fixes" in the sentence "When
fixing CVEs or backporting bugfixes, changes currently require PRs to 15+
repositories." so the line reads "When fixing CVEs or backporting bug fixes,
changes currently require PRs to 15+ repositories." This updates the style while
preserving meaning and formatting in the same paragraph.
|
@ckandag: This pull request references GCP-375 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the spike to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@ckandag: This pull request references GCP-375 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the spike to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
2 participants
Ref: https://issues.redhat.com/browse/GCP-375
Add two implementation plan documents for enabling GCP Persistent Disk
CSI driver support on GCP Hosted Control Planes:
gcp-persistent-disk-csi-driver.md: High-level plan covering component
flow, credential architecture (WIF), CR dependencies, and work areas
across HyperShift Operator, CPO, HCCO, and csi-operator.
gcp-pd-csi-operator-migration.md: Detailed migration plan for moving
gcp-pd-csi-driver-operator into the csi-operator monorepo, covering
Stage 1 (blind copy), Stage 2 (HyperShift integration), asset
generation, deployment hooks, and CI/build pipeline updates.
Signed-off-by: Chaitanya Kandagatla ckandaga@redhat.com
Assisted-by: Cursor (cursor.com)