make it possible to have separate serialization API types and the client to access them #219
Conversation
deads2k
force-pushed
the
select-generator
branch
from
a0ac210 to
822570a
Compare
deads2k
force-pushed
the
select-generator
branch
from
01309d9 to
ad97d89
Compare
deads2k
changed the title
deads2k
force-pushed
the
select-generator
branch
from
ad97d89 to
ba2daee
Compare
deads2k
changed the title
|
/test all |
|
@deads2k Mind adding UTs? These usually provide helpful examples. |
Ah, the unit tests aren't in the package using the standard |
openshift-merge-robot
added
the
needs-rebase
Once we are happy with sdk-go and have used it for a month or so, we can come back and remove old generation and test because we won't come back to it.
openshift-merge-robot
removed
the
needs-rebase
| } | ||
|
|
||
| switch generator { | ||
| case "builders-alias", "json-alias", "types-alias": |
There was a problem hiding this comment.
Mind adding a comment here please? [Explaining that these are run for the ocm-model explicitly.]
| {{ $unmarshalTypeFunc := unmarshalTypeFunc .Type }} | ||
| {{ $readTypeFunc := readTypeFunc .Type }} | ||
| var {{ $marshalTypeFunc }} = {{ apiVersionPackage }}.{{ $marshalTypeFunc }} |
There was a problem hiding this comment.
Ultimately the this will generate the code of the SDK. Shouldn't we have the comments here?
i.e.
// {{ $marshalTypeFunc }} writes a value of the '{{ .Type.Name }}' type to the given writer.
|
/lgtm |
openshift-ci
bot
added
the
do-not-merge/hold
|
This looks good, thanks @deads2k /approve |
openshift-ci
bot
removed
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, vkareh The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
openshift-merge-bot
bot
merged commit 2defa0d
into
openshift-online:main
|
IOUs are here: #229 |
5 participants
This will allow us to split the definition of API types from API client. While doing this, it is worthwhile to continue making it possible for those who wish to generate their own client it its entirety. This is useful for cases where we create a model and choose not to create a client for it. If we don't do that, then it isn't useful and isn't needed.
remaining