Skip to content

use ginkgo junit.xml output #225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nimrodshn merged 1 commit into from
May 7, 2025
Merged

use ginkgo junit.xml output #225

nimrodshn merged 1 commit into from
May 7, 2025

Conversation

@deads2k
Copy link
Contributor

@deads2k deads2k commented Apr 24, 2025

this will produce nice spyglass results.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 24, 2025
@openshift-ci openshift-ci bot requested review from mnecas and nimrodshn April 24, 2025 19:53
@deads2k
Copy link
Contributor Author

deads2k commented May 1, 2025

/assign @nimrodshn

@deads2k deads2k changed the title [wip] use ginkgo junit.xml output use ginkgo junit.xml output May 1, 2025
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 1, 2025
@deads2k deads2k changed the title use ginkgo junit.xml output [wip] use ginkgo junit.xml output May 5, 2025
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 5, 2025
@deads2k deads2k changed the title [wip] use ginkgo junit.xml output use ginkgo junit.xml output May 5, 2025
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 5, 2025
@deads2k
Copy link
Contributor Author

deads2k commented May 5, 2025

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented May 5, 2025

@deads2k: you cannot LGTM your own PR.

Details

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@deads2k
Copy link
Contributor Author

deads2k commented May 5, 2025

/approve

@deads2k
Copy link
Contributor Author

deads2k commented May 5, 2025

/hold so we don't merge on label apply

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 5, 2025
@deads2k deads2k added approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. labels May 5, 2025
@openshift-ci
Copy link

openshift-ci bot commented May 5, 2025

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: deads2k

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deads2k deads2k removed approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. labels May 5, 2025
@deads2k
Copy link
Contributor Author

deads2k commented May 5, 2025

/retest

@deads2k
Copy link
Contributor Author

deads2k commented May 5, 2025

/test ci/prow/unit

@openshift-ci
Copy link

openshift-ci bot commented May 5, 2025

@deads2k: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test images

/test unit

/test verify

Use /test all to run all jobs.

Details

In response to this:

/test ci/prow/unit

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@deads2k
Copy link
Contributor Author

deads2k commented May 5, 2025

/test unit

@deads2k
Copy link
Contributor Author

deads2k commented May 5, 2025

/test all

@deads2k
Copy link
Contributor Author

deads2k commented May 5, 2025

/joke

@openshift-ci
Copy link

openshift-ci bot commented May 5, 2025

@deads2k: Want to hear a chimney joke? Got stacks of em! First one's on the house

Details

In response to this:

/joke

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@deads2k
Copy link
Contributor Author

deads2k commented May 5, 2025

/hold cancel

/assign @nimrodshn

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 5, 2025
@nimrodshn
Copy link
Collaborator

nimrodshn commented May 7, 2025

LGTM 💯

@nimrodshn
Copy link
Collaborator

nimrodshn commented May 7, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 7, 2025
@nimrodshn
Copy link
Collaborator

nimrodshn commented May 7, 2025

/approved

@nimrodshn nimrodshn added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 7, 2025
@nimrodshn nimrodshn merged commit 8bcf554 into openshift-online:main May 7, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mnecas mnecas Awaiting requested review from mnecas

@nimrodshn nimrodshn Awaiting requested review from nimrodshn

Assignees

@nimrodshn nimrodshn

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@deads2k @nimrodshn