Skip to content

Conversation

@ahitacat
Copy link
Contributor

@ahitacat ahitacat commented Jun 2, 2025

When adding the version_type.model PR definition to aro_hcp the metamodel fails to generate read it with the following error:

E: Type 'Version' is already defined
E: Can't read model: there was 1 error
make: *** [Makefile:53: openapi] Error 1

This is due to 'version' is already part of the service as it was previously read (via node pool), and when reading the definition for 'version' in aro_hcp service it fails.

This commit fix this case, by checking if an defined type has the reference annotation. In this case, it sets this type as an ExplicitDeclared type and fix the ownership in the attributes that the reader has already read.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 2, 2025
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Jun 2, 2025

@ahitacat: This pull request references OCM-16102 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.20.0" version, but no target version was set.

Details

In response to this:

When adding the version_type.model PR definition to aro_hcp the metamodel fails to generate read it with the following error:

E: Type 'Version' is already defined
E: Can't read model: there was 1 error
make: *** [Makefile:53: openapi] Error 1

This is due to 'version' is already part of the service as it was previously read (via node pool), and when reading the definition for 'version' in aro_hcp service it fails.

This commit fix this case, by checking if an defined type has the reference annotation. In this case, it sets this type as an ExplicitDeclared type and fix the ownership in the attributes that the reader has already read.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ahitacat ahitacat requested a review from nimrodshn June 2, 2025 13:08
@openshift-ci openshift-ci bot requested a review from mnecas June 2, 2025 13:08
Copy link
Collaborator

@nimrodshn nimrodshn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 3, 2025
@openshift-ci
Copy link

openshift-ci bot commented Jun 3, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahitacat, nimrodshn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 3, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 9ff0bff into openshift-online:main Jun 3, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants