Skip to content

Conversation

@JameelB
Copy link
Contributor

@JameelB JameelB commented Jun 11, 2025

This follows on from PR #208 which added initial support for asynchronous methods Delete and Update.

This adds 2 new asynchronous methods for Add and Post which will be used for generating endpoints for v1alpha1 of the aro_hcp API (see openshift-online/ocm-api-model#1047 (comment)).

@openshift-ci openshift-ci bot requested review from mnecas and nimrodshn June 11, 2025 16:34
@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 11, 2025
@openshift-ci
Copy link

openshift-ci bot commented Jun 11, 2025

Hi @JameelB. Thanks for your PR.

I'm waiting for a openshift-online member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@JameelB
Copy link
Contributor Author

JameelB commented Jun 11, 2025

PTAL @nimrodshn and @ahitacat 🙏

@ahitacat
Copy link
Contributor

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 12, 2025
@openshift-ci
Copy link

openshift-ci bot commented Jun 12, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahitacat, JameelB

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 12, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 488a7c2 into openshift-online:main Jun 12, 2025
5 checks passed
@nimrodshn
Copy link
Collaborator

TY @JameelB 🙏

@miguelsorianod
Copy link
Contributor

For now this is good enough but I want to raise awareness that this approach will fall short if for some reason we end up having some asynchronous endpoints that don't use HTTP 202, but 201. I mention this because the ocm api model is shared between offerings, not only aro-hcp.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants