Skip to content

Conversation

@tzvatot
Copy link
Contributor

@tzvatot tzvatot commented Jul 20, 2025

@openshift-ci openshift-ci bot requested review from ahitacat and nimrodshn July 20, 2025 19:14
@openshift-ci
Copy link

openshift-ci bot commented Jul 20, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tzvatot
Once this PR has been reviewed and has the lgtm label, please assign vkareh for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tzvatot
Copy link
Contributor Author

tzvatot commented Jul 30, 2025

@ahitacat @nimrodshn PTAL

@jhernand
Copy link
Collaborator

Consider adding this kind of check to https://github.com/openshift-online/ocm-api-metamodel/blob/main/pkg/language/checks.go, that way it will be checked way before trying to generate code.

@tzvatot
Copy link
Contributor Author

tzvatot commented Jul 30, 2025

Consider adding this kind of check to https://github.com/openshift-online/ocm-api-metamodel/blob/main/pkg/language/checks.go, that way it will be checked way before trying to generate code.

Thanks! I will make the change, closing this PR

@tzvatot tzvatot closed this Jul 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants