OCM-17280 | feat: Add support for deprecated annotation #238
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nimrodshn
reviewed
Jul 24, 2025
nimrodshn
reviewed
Jul 24, 2025
nimrodshn
reviewed
Jul 24, 2025
tzvatot
force-pushed
the
support-deprecated-api
branch
from
dc5ad23 to
b3561a4
Compare
Collaborator
|
Can you please add UT? |
Contributor
Author
Done |
Collaborator
|
I ment the e2e tests under |
Collaborator
|
/lgtm |
Collaborator
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nimrodshn, tzvatot The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Contributor
Author
Discussed on slack:
|
openshift-merge-bot
bot
merged commit b2070b5
into
openshift-online:main
5 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ahitacat @nimrodshn PTAL