OCM-17408 | fix: handle non error status code with EOF to not return an error #240
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahitacat
reviewed
Jul 29, 2025
ahitacat
reviewed
Jul 29, 2025
ahitacat
reviewed
Jul 29, 2025
Contributor
ahitacat
left a comment
ahitacat
left a comment
There was a problem hiding this comment.
These comments are the same as the one you just removed.
Contributor
|
/lgtm |
Contributor
|
@nimrodshn can you take a look at this and approve it? |
ahitacat
approved these changes
Jul 29, 2025
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahitacat, tzvatot The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
openshift-merge-bot
bot
merged commit dac2bd1
into
openshift-online:main
5 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@nimrodshn @ahitacat PTAL
This is in respond to #162 (comment)