-
Notifications
You must be signed in to change notification settings - Fork 151
Bump github.com/onsi/gomega from 1.38.3 to 1.39.1 #1000
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Bump github.com/onsi/gomega from 1.38.3 to 1.39.1 #1000
Conversation
WalkthroughUpdated three Go module dependencies in Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: dependabot[bot] The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @dependabot[bot]. Thanks for your PR. I'm waiting for a openshift-online member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@go.mod`:
- Around line 17-18: The go.mod dependency upgrades to github.com/onsi/ginkgo/v2
v2.28.0 and github.com/onsi/gomega v1.39.1 raise the minimum required Go
toolchain to Go 1.24; verify and ensure the project uses Go >=1.24 by updating
the module's Go directive (the "go" version in go.mod) and any CI/build matrices
(e.g., GitHub Actions, Dockerfiles, or Makefiles) to 1.24 or higher, or if you
must support older toolchains, revert these dependency versions; locate the
go.mod "go" directive and CI config jobs that specify Go versions to make the
change.
| github.com/onsi/ginkgo/v2 v2.28.0 | ||
| github.com/onsi/gomega v1.39.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🌐 Web query:
gomega 1.39.1 release notes changelog
💡 Result:
Gomega v1.39.1 (released Jan 30, 2026) — release notes / changelog
- Maintenance: “Update all dependencies.”
- Go version requirement: This dependency update bumps the required Go version to Go 1.24, noting that Go 1.23 had been out of support for almost six months. [1]
(Version confirmation: GOMEGA_VERSION = "1.39.1" on pkg.go.dev.) [2]
Sources:
[1] onsi/gomega GitHub Releases (v1.39.1) (github.com)
[2] pkg.go.dev docs for github.com/onsi/gomega (pkg.go.dev)
Citations:
- 1: https://github.com/onsi/gomega/releases
- 2: https://pkg.go.dev/github.com/onsi/gomega?utm_source=openai
🌐 Web query:
ginkgo v2.28.0 release notes changelog breaking changes
💡 Result:
Ginkgo v2.28.0 — release notes / changelog highlights
- Feature: Ginkgo’s SemVer filtering now supports filtering multiple components (not just a single suite version). This adds a new decorator and CLI filter syntax, e.g.
ComponentSemVerConstraint("redis", ">= 8.0.0")andginkgo --sem-ver-filter="2.1.1, redis=8.2.0". [1] - API additions:
ComponentSemVerConstraint(...)/ComponentSemVerConstraintswere added in v2.28.0. [2]
Breaking changes in v2.28.0
- None called out in the upstream v2.28.0 release notes. [1]
(If you’re upgrading within the 2.28 line: v2.28.1 also updated dependencies and bumps the required Go version to 1.24, which can be breaking for projects pinned to older Go versions.) [3]
Sources: [1] [2] [3]
Verify Go version requirements for gomega 1.39.1 and ginkgo v2.28.0.
These updates bump the minimum required Go version to Go 1.24 (Go 1.23 is out of support). Confirm the project's Go version supports this requirement before merging. The libraries themselves have no API breaking changes—gomega v1.39.1 only updates dependencies, and ginkgo v2.28.0 adds new SemVer filtering features without breaking existing functionality.
🤖 Prompt for AI Agents
In `@go.mod` around lines 17 - 18, The go.mod dependency upgrades to
github.com/onsi/ginkgo/v2 v2.28.0 and github.com/onsi/gomega v1.39.1 raise the
minimum required Go toolchain to Go 1.24; verify and ensure the project uses Go
>=1.24 by updating the module's Go directive (the "go" version in go.mod) and
any CI/build matrices (e.g., GitHub Actions, Dockerfiles, or Makefiles) to 1.24
or higher, or if you must support older toolchains, revert these dependency
versions; locate the go.mod "go" directive and CI config jobs that specify Go
versions to make the change.
Bumps [github.com/onsi/gomega](https://github.com/onsi/gomega) from 1.38.3 to 1.39.1. - [Release notes](https://github.com/onsi/gomega/releases) - [Changelog](https://github.com/onsi/gomega/blob/master/CHANGELOG.md) - [Commits](onsi/gomega@v1.38.3...v1.39.1) --- updated-dependencies: - dependency-name: github.com/onsi/gomega dependency-version: 1.39.1 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
330a05f to
3820d87
Compare
Bumps github.com/onsi/gomega from 1.38.3 to 1.39.1.
Release notes
Sourced from github.com/onsi/gomega's releases.
Changelog
Sourced from github.com/onsi/gomega's changelog.
Commits
1a25a36v1.39.1406faeebump all deps49561adv1.39.08f7f425document MatchErrorStrictlybae643dadd matcher relecting errors.Is behaviorDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)