Build(deps): Bump go.opentelemetry.io/otel/sdk from 1.39.0 to 1.43.0#1086
Build(deps): Bump go.opentelemetry.io/otel/sdk from 1.39.0 to 1.43.0#1086dependabot[bot] wants to merge 1 commit intomainfrom
Conversation
Bumps [go.opentelemetry.io/otel/sdk](https://github.com/open-telemetry/opentelemetry-go) from 1.39.0 to 1.43.0. - [Release notes](https://github.com/open-telemetry/opentelemetry-go/releases) - [Changelog](https://github.com/open-telemetry/opentelemetry-go/blob/main/CHANGELOG.md) - [Commits](open-telemetry/opentelemetry-go@v1.39.0...v1.43.0) --- updated-dependencies: - dependency-name: go.opentelemetry.io/otel/sdk dependency-version: 1.43.0 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: dependabot[bot] The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @dependabot[bot]. Thanks for your PR. I'm waiting for a openshift-online member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
WalkthroughUpdated Go toolchain version from 1.24.13 to 1.25.0 and bumped OpenTelemetry module versions from v1.39.0 to v1.43.0, along with golang.org/x/sys from v0.40.0 to v0.42.0. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@go.mod`:
- Line 3: CI workflows pin older Go versions than go.mod. In the workflow YAMLs
update every go-version key to 1.25: change go-version: 1.23 → 1.25 in
publish-release.yaml (the go-version entry under the job that builds/releases)
and change go-version: 1.22 and go-version: 1.23 → 1.25 in
check-pull-request.yaml (both the matrix or explicit go-version entries used in
the jobs). Ensure you update all occurrences of the go-version key so CI tests
and release actions run with Go 1.25.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 4fc8b61e-4306-42a9-b28d-1b7993f3ba33
⛔ Files ignored due to path filters (1)
go.sumis excluded by!**/*.sum
📒 Files selected for processing (1)
go.mod
| module github.com/openshift-online/ocm-cli | ||
|
|
||
| go 1.24.13 | ||
| go 1.25.0 |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "Checking Go version pins in common CI/build files..."
fd -HI 'go\.mod|go\.work|Dockerfile|Containerfile|\.tool-versions|Makefile|.*\.ya?ml' | \
xargs -r rg -n --no-heading -e '\bgo\s*[:= ]\s*1\.' -e 'golang:1\.' -e 'go-version' -e 'GOVERSION' -e 'GO_VERSION'Repository: openshift-online/ocm-cli
Length of output: 396
Update CI workflow Go versions to match go.mod 1.25.0.
The go.mod bump to 1.25.0 is not reflected in CI/release workflows. The workflows still pin to Go 1.22 and 1.23, which means:
- CI will not verify code against the declared minimum Go version
- Incompatibilities with 1.25.0 could slip through undetected
Update:
.github/workflows/publish-release.yamlline 45:go-version: 1.23→1.25.github/workflows/check-pull-request.yamllines 51 and 77:go-version: 1.22and1.23→1.25
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@go.mod` at line 3, CI workflows pin older Go versions than go.mod. In the
workflow YAMLs update every go-version key to 1.25: change go-version: 1.23 →
1.25 in publish-release.yaml (the go-version entry under the job that
builds/releases) and change go-version: 1.22 and go-version: 1.23 → 1.25 in
check-pull-request.yaml (both the matrix or explicit go-version entries used in
the jobs). Ensure you update all occurrences of the go-version key so CI tests
and release actions run with Go 1.25.
Bumps go.opentelemetry.io/otel/sdk from 1.39.0 to 1.43.0.
Changelog
Sourced from go.opentelemetry.io/otel/sdk's changelog.
... (truncated)
Commits
9276201Release v1.43.0 / v0.65.0 / v0.19.0 (#8128)61b8c94chore(deps): update module github.com/mattn/go-runewidth to v0.0.22 (#8131)97a086echore(deps): update github.com/golangci/dupl digest to c99c5cf (#8122)5e363delimit response body size for OTLP HTTP exporters (#8108)35214b6Use an absolute path when calling bsd kenv (#8113)290024cfix(deps): update module google.golang.org/grpc to v1.80.0 (#8121)e70658efix: support getBody in otelploghttp (#8096)4afe468fix(deps): update googleapis to 9d38bb4 (#8117)b9ca729chore(deps): update module github.com/go-git/go-git/v5 to v5.17.2 (#8115)69472ecchore(deps): update fossas/fossa-action action to v1.9.0 (#8118)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.