Build(deps): Bump golang.org/x/term from 0.39.0 to 0.42.0#1092
Build(deps): Bump golang.org/x/term from 0.39.0 to 0.42.0#1092dependabot[bot] wants to merge 1 commit intomainfrom
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
WalkthroughGo toolchain directive updated from Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: dependabot[bot] The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @dependabot[bot]. Thanks for your PR. I'm waiting for a openshift-online member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@go.mod`:
- Line 3: go.mod now declares "go 1.25.0" but the CI workflows still pin older
Go versions; update every workflow step that sets the setup-go input key
"go-version" (e.g., where actions/setup-go@... is used) to "1.25.0" so the
workflows match the module minimum; search for occurrences of go-version: 1.22
and 1.23 and replace them with go-version: 1.25.0 to keep CI and go.mod
consistent.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: c5e96d16-9982-44cd-81c7-1f84bbd4c91a
⛔ Files ignored due to path filters (1)
go.sumis excluded by!**/*.sum
📒 Files selected for processing (1)
go.mod
| module github.com/openshift-online/ocm-cli | ||
|
|
||
| go 1.24.13 | ||
| go 1.25.0 |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Read-only verification of Go version pins across repo config/docs.
set -euo pipefail
echo "== Files that may pin Go versions =="
fd -HI '(^|/)(go\.mod|go\.work|\.tool-versions|Dockerfile|dockerfile|Makefile|.*\.yml|.*\.yaml|README.*)$'
echo
echo "== Mentions of Go versions / setup-go =="
rg -n --iglob '*.yml' --iglob '*.yaml' --iglob 'Dockerfile*' --iglob 'Makefile*' --iglob 'README*' \
'setup-go|go-version|golang:|GO_VERSION|go[[:space:]]+[0-9]+\.[0-9]+'
echo
echo "== go.mod directive =="
rg -n '^go[[:space:]]+'Repository: openshift-online/ocm-cli
Length of output: 665
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "=== GitHub Workflows (setup-go usage) ==="
for f in .github/workflows/*.yaml .github/workflows/*.yml; do
[ -f "$f" ] && echo "File: $f" && grep -A 2 -B 2 'setup-go\|go-version' "$f" || true
done
echo
echo "=== Dockerfile Go base image ==="
[ -f docker/Dockerfile ] && cat -n docker/Dockerfile | grep -i 'from.*golang\|from.*go:' || echo "No golang/go base image found"
echo
echo "=== Makefile Go version checks ==="
[ -f Makefile ] && (grep -n 'go[[:space:]]*[0-9]\|GO_VERSION\|GOLANG' Makefile || echo "No explicit Go version in Makefile") || true
echo
echo "=== go.mod current directive ==="
head -5 go.mod | grep -n '^go'
echo
echo "=== Tekton configs Go version refs ==="
for f in .tekton/*.yaml; do
[ -f "$f" ] && grep -n 'go[[:space:]]*[0-9]\|setup-go\|golang' "$f" || true
doneRepository: openshift-online/ocm-cli
Length of output: 922
Update GitHub workflows to use Go 1.25.0 to match go.mod.
The go.mod bump to 1.25.0 creates a mismatch with CI workflows: .github/workflows/check-pull-request.yaml pins Go 1.22 and 1.23, while .github/workflows/publish-release.yaml uses 1.23. These will fail when running against the new 1.25.0 minimum. Update both workflows to use go-version: 1.25.0.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@go.mod` at line 3, go.mod now declares "go 1.25.0" but the CI workflows still
pin older Go versions; update every workflow step that sets the setup-go input
key "go-version" (e.g., where actions/setup-go@... is used) to "1.25.0" so the
workflows match the module minimum; search for occurrences of go-version: 1.22
and 1.23 and replace them with go-version: 1.25.0 to keep CI and go.mod
consistent.
Bumps [golang.org/x/term](https://github.com/golang/term) from 0.39.0 to 0.42.0. - [Commits](golang/term@v0.39.0...v0.42.0) --- updated-dependencies: - dependency-name: golang.org/x/term dependency-version: 0.42.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
d44d603 to
dfbbe26
Compare
Bumps golang.org/x/term from 0.39.0 to 0.42.0.
Commits
52b71d3go.mod: update golang.org/x dependencies9d2dc07go.mod: update golang.org/x dependenciesd954e03all: upgrade go directive to at least 1.25.0 [generated]3aff304go.mod: update golang.org/x dependencies