Build(deps): Bump github.com/onsi/ginkgo/v2 from 2.17.1 to 2.28.3#157
Build(deps): Bump github.com/onsi/ginkgo/v2 from 2.17.1 to 2.28.3#157dependabot[bot] wants to merge 1 commit into
Conversation
Summary by CodeRabbit
WalkthroughThe Go module definition is updated to target Go 1.25.0 and refreshes multiple direct and indirect dependencies to newer versions, including testing libraries (ginkgo/v2, gomega), cryptography support (golang.org/x/crypto), and various utility modules. ChangesDependency Version Updates
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Warning Review ran into problems🔥 ProblemsGit: Failed to clone repository. Please run the Comment |
Bumps [github.com/onsi/ginkgo/v2](https://github.com/onsi/ginkgo) from 2.17.1 to 2.28.3. - [Release notes](https://github.com/onsi/ginkgo/releases) - [Changelog](https://github.com/onsi/ginkgo/blob/master/CHANGELOG.md) - [Commits](onsi/ginkgo@v2.17.1...v2.28.3) --- updated-dependencies: - dependency-name: github.com/onsi/ginkgo/v2 dependency-version: 2.28.2 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
22c595b to
230cac0
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@go.mod`:
- Line 3: The go.mod module directive currently reads "go 1.25.0" but CI
workflows still pin "go-version: '1.24.7'"; either update all CI workflow
go-version entries to "1.25.0" so CI matches the go.mod directive, or revert the
go.mod directive back to "1.24.7" and regenerate the module lock files (go.sum)
to keep versions consistent; look for the "go 1.25.0" token in go.mod and the
"go-version: '1.24.7'" tokens in your workflow YMLs to make the corresponding
changes.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Enterprise
Run ID: 569a5418-6c70-41f3-967e-62480457d4dc
⛔ Files ignored due to path filters (1)
go.sumis excluded by!**/*.sum
📒 Files selected for processing (1)
go.mod
| module github.com/openshift-online/ocm-common | ||
|
|
||
| go 1.24.7 | ||
| go 1.25.0 |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "== go directive(s) =="
rg -n --hidden -S '^go [0-9]+\.[0-9]+(\.[0-9]+)?$' -g 'go.mod' -g 'go.work' || true
echo
echo "== CI/tooling Go version references =="
rg -n --hidden -S 'go-version:|GO_VERSION|golang:[0-9]+\.[0-9]+' \
-g '**/.github/workflows/*.yml' \
-g '**/.github/workflows/*.yaml' \
-g 'Dockerfile*' \
-g '.tool-versions' || true
echo
echo "Expected: all discovered version pins align with the go.mod baseline (or are intentionally documented mismatches)."Repository: openshift-online/ocm-common
Length of output: 490
Update CI workflows to match go.mod directive, or revert the Go version bump
Line 3 sets the module go directive to 1.25.0, but CI workflows still pin go-version: '1.24.7' in .github/workflows/publish-release.yml and .github/workflows/check-pull-request.yml. This mismatch means CI won't validate builds against the declared minimum Go version. Either update all workflow references to 1.25.0, or revert the go.mod directive to 1.24.7 and regenerate the lock file.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@go.mod` at line 3, The go.mod module directive currently reads "go 1.25.0"
but CI workflows still pin "go-version: '1.24.7'"; either update all CI workflow
go-version entries to "1.25.0" so CI matches the go.mod directive, or revert the
go.mod directive back to "1.24.7" and regenerate the module lock files (go.sum)
to keep versions consistent; look for the "go 1.25.0" token in go.mod and the
"go-version: '1.24.7'" tokens in your workflow YMLs to make the corresponding
changes.
Bumps github.com/onsi/ginkgo/v2 from 2.17.1 to 2.28.3.
Release notes
Sourced from github.com/onsi/ginkgo/v2's releases.
... (truncated)
Changelog
Sourced from github.com/onsi/ginkgo/v2's changelog.
... (truncated)
Commits
5de9c15v2.28.37e2fa19bump dependencies1a81912v2.28.2f3a36b6Add ArtifactDir() to support Go 1.26 testing.TB interface94151c8Implement shell completion4d21dbbAdd asan CLI option mirroring msan implementationc102161Bump uri from 1.0.3 to 1.0.4 in /docs (#1630)9619647fix aspect ratio5779304update logos5d1d628v2.28.1