Skip to content

fix: remove automated opc version updates#488

Merged
divyansh42 merged 1 commit into
openshift-pipelines:mainfrom
divyansh42:fix-upgrades
Jul 10, 2026
Merged

fix: remove automated opc version updates#488
divyansh42 merged 1 commit into
openshift-pipelines:mainfrom
divyansh42:fix-upgrades

Conversation

@divyansh42

Copy link
Copy Markdown
Contributor

Assisted-by: Claude Opus 4.6 (via Cursor)

Signed-off-by: divyansh42 <diagrawa@redhat.com>
Assisted-by: Claude Opus 4.6 (via Cursor)
@divyansh42 divyansh42 changed the title fix: use hack repo release config for opc version fix: remove automated opc version updates Jul 9, 2026
@fullsend-ai-review

fullsend-ai-review Bot commented Jul 9, 2026

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 6:21 PM UTC · Completed 6:25 PM UTC
Commit: 0195edd · View workflow run →

@fullsend-ai-review

Copy link
Copy Markdown

Review — approve

Scope: Removes the self-referential OPC version auto-update logic from the update-patch-versions.sh CI script and the corresponding TARGET_BRANCH environment variable from the workflow.

Changes reviewed

File Change
.github/scripts/update-patch-versions.sh Removed 32-line block that fetched OPC tags from GitHub API and updated OPC_VERSION in the Makefile for release branches
.github/workflows/auto-update-components.yml Removed TARGET_BRANCH env var passed to the update script

Analysis

Correctness: The deletion is clean with no residual references. After this change:

  • TARGET_BRANCH is no longer referenced anywhere in the codebase.
  • OPC_REPO was only used within the removed block.
  • The remaining component update loop (pac, tkn, results, manualapprovalgate) is completely untouched and continues to function.
  • The UPDATES array, GOMOD_CHANGED flag, and downstream logic (go mod tidy/vendor, make generate, output variables) remain intact.

Impact: On main, this is a no-op — the removed code already skipped OPC version updates on main ("Skipping opc version update on main (using devel)"), and OPC_VERSION remains devel in the Makefile. On release branches, OPC_VERSION will no longer be auto-bumped to the latest matching patch tag. Given this repo was updating its own version (self-referential: OPC_REPO="openshift-pipelines/opc"), removing this circular auto-update is a reasonable fix.

Security: No concerns — pure deletion of CI automation code with no new attack surface.

Intent coherence: The PR title "fix: remove automated opc version updates" exactly matches the code change. The fix: prefix suggests the auto-update was causing unintended behavior.

No findings.


Protected paths detected — this PR modifies files under one or more
protected paths. The review agent cannot approve PRs that touch these paths.
A human reviewer must approve this PR.

Protected files in this PR:

  • .github/scripts/update-patch-versions.sh
  • .github/workflows/auto-update-components.yml

Labels: PR modifies GitHub Actions workflow and CI scripts

@fullsend-ai-review fullsend-ai-review Bot added requires-manual-review Review requires human judgment github_actions Pull requests that update GitHub Actions code labels Jul 9, 2026
@divyansh42
divyansh42 merged commit 5e159ff into openshift-pipelines:main Jul 10, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

github_actions Pull requests that update GitHub Actions code requires-manual-review Review requires human judgment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants