Configure E2E test setup on PAC for bitbucket server #1820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1820 +/- ##
==========================================
+ Coverage 65.34% 65.35% +0.01%
==========================================
Files 177 177
Lines 13594 13594
==========================================
+ Hits 8883 8885 +2
+ Misses 4119 4117 -2
Partials 592 592 ☔ View full report in Codecov by Sentry. |
zakisk
force-pushed
the
SRVKP-6758
branch
7 times, most recently
from
cbaa344 to
f515e53
Compare
chmouel
reviewed
Nov 18, 2024
zakisk
force-pushed
the
SRVKP-6758
branch
3 times, most recently
from
b8764c8 to
341bea6
Compare
|
/test |
chmouel
reviewed
Jan 15, 2025
configured e2e test for bitbucket server on PAC and wrote one test for pull request. https://issues.redhat.com/browse/SRVKP-6758 Signed-off-by: Zaki Shaikh <[email protected]>
chmouel
requested changes
Jan 17, 2025
test/pkg/bitbucketserver/pr.go
Outdated
| return pr | ||
| } | ||
|
|
||
| // pushFilesToBranch pushes multiple files to bitbucket server repo because |
There was a problem hiding this comment.
you can use the scm test library that pushes with git cli instead like we do for gitea/gitlab https://github.com/openshift-pipelines/pipelines-as-code/blob/main/test/gitlab_merge_request_test.go#L57-L68 but that's fine if it works for now altho this would generate multiple event when pushing which may cause unexpected behaviours
There was a problem hiding this comment.
you're right! pushing multiple times might cause issues, now using git CLI.
used git cli to push files to repo because Bitbucket REST API doesn't allow to push multiple files. Signed-off-by: Zaki Shaikh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
configured e2e test for bitbucket server on PAC and wrote one test for pull request.
Upstream issue: #522
https://issues.redhat.com/browse/SRVKP-6758
Changes
Submitter Checklist
📝 Please ensure your commit message is clear and informative. For guidance on crafting effective commit messages, refer to the How to write a git commit message guide. We prefer the commit message to be included in the PR body itself rather than a link to an external website (ie: Jira ticket).
♽ Before submitting a PR, run make test lint to avoid unnecessary CI processing. For an even more efficient workflow, consider installing pre-commit and running pre-commit install in the root of this repository.
✨ We use linters to maintain clean and consistent code. Please ensure you've run make lint before submitting a PR. Some linters offer a --fix mode, which can be executed with the command make fix-linters (ensure markdownlint and golangci-lint tools are installed first).
📖 If you're introducing a user-facing feature or changing existing behavior, please ensure it's properly documented.
🧪 While 100% coverage isn't a requirement, we encourage unit tests for any code changes where possible.
🎁 If feasible, please check if an end-to-end test can be added. See README for more details.
🔎 If there's any flakiness in the CI tests, don't necessarily ignore it. It's better to address the issue before merging, or provide a valid reason to bypass it if fixing isn't possible (e.g., token rate limitations).