Skip to content

Conversation

@bmangoen
Copy link
Contributor

Pulling upstream Istio up to 1.26.8 tag

kayneb and others added 23 commits October 17, 2025 06:35
* Pin curl version (#57954)

* Use fully qualified names for images in samples

Signed-off-by: mkralik3 <[email protected]>

---------

Signed-off-by: mkralik3 <[email protected]>
Co-authored-by: Steven Jin <[email protected]>
* Cherry-pick 57361 without ambient multicluster

There was a large change between 1.26 and 1.27 so this PR only copies
the cleanup bits that are relevant to sidecar mode

Signed-off-by: Keith Mattix II <[email protected]>

* Handle multicluster cleanup

Signed-off-by: Keith Mattix II <[email protected]>

* Handle multicluster cleanup (#58093)

* Handle multicluster cleanup

Signed-off-by: Keith Mattix II <[email protected]>

* More cleanup to stop leak

Signed-off-by: Keith Mattix II <[email protected]>

* Address PR comments

Signed-off-by: Keith Mattix II <[email protected]>

---------

Signed-off-by: Keith Mattix II <[email protected]>

* Add release note

Signed-off-by: Keith Mattix II <[email protected]>

---------

Signed-off-by: Keith Mattix II <[email protected]>
* add resource name to secret resource

Signed-off-by: Rama Chavali <[email protected]>

* add release notes

Signed-off-by: Rama Chavali <[email protected]>

---------

Signed-off-by: Rama Chavali <[email protected]>
Co-authored-by: Rama Chavali <[email protected]>
Just get all the addresses and compare.

Asking for the addresses on an interface is just filtering all the
addresses by the interface index. Rather than do it N times, just do it
once.

This shaves about 20-30ms per repair. The majority of the time is still
in the actual iptable repair.
…server route creation (#58205)

* Fix gateway merging bug: HTTPS server preventing HTTP server route creation

When an HTTPS server is processed first on a port, it was preventing HTTP
servers from building correct routes on the same port but with different
bind addresses.

Root cause: The plainTextServers map was keyed only by port number instead
of the full ServerPort struct (port + protocol + bind). This caused HTTP
servers with different binds to be incorrectly treated as TLS conflicts.

Changes:
- Fixed plainTextServers data structure from map[uint32]ServerPort to map[ServerPort]ServerPort
- Updated conflict detection logic to use ServerPort struct as key
- Added logic to handle plaintext servers with different binds as separate servers
- Added comprehensive unit test TestMergeGatewaysHttpsFirstBug

Fixes: Gateway merging issue where HTTPS-first processing prevents HTTP route creation

* address comment

* address comments

* address comment

* address comment

---------

Co-authored-by: Chen, Shone <[email protected]>
Istio release 1.26.8

Signed-off-by: bmangoen <[email protected]>
Copy link

@ferhoyos ferhoyos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bmangoen
Copy link
Contributor Author

/retest

1 similar comment
@bmangoen
Copy link
Contributor Author

/retest

@openshift-ci
Copy link

openshift-ci bot commented Jan 20, 2026

@bmangoen: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/integ-ambient 16cf872 link true /test integ-ambient

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@FilipB
Copy link
Collaborator

FilipB commented Jan 21, 2026

/retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants