WRKLDS-1380: DeploymentConfig: drop capability from the enabled-by-default set #1954
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@ingvagabund: This pull request references WRKLDS-1380 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Hello @ingvagabund! Some important instructions when contributing to openshift/api: |
openshift-ci
bot
added
the
size/XS
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ingvagabund The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest-required |
|
openshift/cluster-version-operator#1073 to resolve the failing unit test. |
|
/retest-required |
|
@ingvagabund: This pull request references WRKLDS-1380 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
|
@ingvagabund: This pull request references WRKLDS-1380 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
|
e2e test migration PR under openshift/origin#28957 |
|
What does the install configuration look like for someone who still needs deployment configs/how will that be documented to show that users can still get deployment configs on new clusters? |
|
We will be updating the openshift docs to mention the DC capability needs to be enabled explicitly if DCs are still needed. The same procedure as for any capability that's currently known but not enabled will be suggested. |
|
@dgoodwin @JoelSpeed one way is to introduce a new periodic job that will run all e2es with all caps enabled. There's no point of running a new e2e with just DeploymentConfig capability enabled in addition. Also probably unlikely to run a new e2e with all caps enabled for every PR across all repositories given how many variants we have. Nevertheless, given the "no capabilities" periodic job is going red I wonder if the new periodic job will end up the same? |
|
Having an all capabilities test makes sense to me, but we need to make sure that something in origin is still exercising the DCs, else that will be pointless. Not sure how to make those tests only run on those particular clusters but I'm sure there's probably precedent for that. |
|
Oh sorry, I wanted to post these comments under openshift/origin#28957. |
DeploymentConfigs are deprecated. They will not get removed from 4.Y. Users are expected to migrate to Deployments wherever possible. Disabling the capability by default is part of making the default installation smaller while providing only the necessary key components.
ingvagabund
force-pushed
the
drop-dc-cap-from-enabled-by-default-set
branch
from
9834d9d to
a36180d
Compare
|
@ingvagabund Do we now have a test that will continue to test DCs into the future once this is merged? Otherwise I think we are ready to merge this aren't we? |
|
Not yet. I am currently discussing how to produce a periodic job testing DC enabled. |
|
I think we need to table this pull request until HyperShift grows support for implicitly-enabled capabilities. See discussion here. So even though there's already a hold on this pull, I'll add my own: /hold I'm not an API approver though; feel free to remove/ignore my hold if the reasoning isn't clear or convincing. |
|
@ingvagabund: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
DeploymentConfigs are deprecated. They will not get removed from 4.Y. Users are expected to migrate to Deployments wherever possible. Disabling the capability by default is part of making the default installation smaller while providing only the necessary key components.
Removal tested in openshift/cluster-version-operator#1066.