Skip to content

WIP: STOR-2136: Enable group snapshots as GA feature #2106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

gnufied
Copy link
Member

@gnufied gnufied commented Nov 20, 2024

No description provided.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 20, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 20, 2024

@gnufied: This pull request references STOR-2136 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

openshift-ci bot commented Nov 20, 2024

Hello @gnufied! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 20, 2024
@openshift-ci openshift-ci bot requested review from abhat and adambkaplan November 20, 2024 01:15
@gnufied gnufied changed the title STOR-2136: Enable group snapshots as GA feature WIP: STOR-2136: Enable group snapshots as GA feature Dec 5, 2024
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 5, 2024
@gnufied gnufied force-pushed the enable-group-snapshots branch from 2372cad to b8406d3 Compare January 23, 2025 21:42
Copy link
Contributor

openshift-ci bot commented Jan 23, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: gnufied
Once this PR has been reviewed and has the lgtm label, please assign joelspeed for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

openshift-ci bot commented Apr 15, 2025

@gnufied: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn b8406d3 link true /test e2e-aws-ovn
ci/prow/e2e-upgrade b8406d3 link true /test e2e-upgrade
ci/prow/e2e-aws-ovn-hypershift b8406d3 link true /test e2e-aws-ovn-hypershift
ci/prow/verify b8406d3 link true /test verify
ci/prow/e2e-aws-serial-techpreview b8406d3 link true /test e2e-aws-serial-techpreview
ci/prow/e2e-aws-ovn-techpreview b8406d3 link true /test e2e-aws-ovn-techpreview
ci/prow/e2e-aws-serial b8406d3 link true /test e2e-aws-serial
ci/prow/verify-feature-promotion b8406d3 link true /test verify-feature-promotion
ci/prow/minor-e2e-upgrade-minor b8406d3 link true /test minor-e2e-upgrade-minor
ci/prow/e2e-upgrade-out-of-change b8406d3 link true /test e2e-upgrade-out-of-change
ci/prow/verify-client-go b8406d3 link true /test verify-client-go
ci/prow/e2e-aws-ovn-hypershift-conformance b8406d3 link true /test e2e-aws-ovn-hypershift-conformance

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants