OCPBUGS-48740: Remove unnecessary object-src directive

[jhadvig]

Based on the conversation with @spadgett and @vojtechszocs we agreed we dont need the object-src directive as we thought and so we will remove it, until its need.

@assign @spadgett @JoelSpeed

[openshift-ci-robot]

@jhadvig: This pull request references Jira Issue OCPBUGS-48740, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.19.0) matches configured target version for branch (4.19.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yapei

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Based on the conversation with @spadgett and @vojtechszocs we agreed we dont need the object-src directive as we thought and so we will remove it, until its need.

@assign @spadgett @JoelSpeed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

Hello @jhadvig! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

[spadgett]

LGTM

[spadgett]

We'll want to update the enhancement as well

[jhadvig]

@spadgett openshift/enhancements#1744

[JoelSpeed]

When did this object ship? Removing a value from an enum is technically a breaking change, has this shipped only in 4.19?

[jhadvig]

it was added just recently, last week

[JoelSpeed]

This was added in #2163 last week. It hasn't hit a released version of the product yet, and as such, this is a compatible change that we can still make without worrying too much. Ratcheting validation would catch this for anyone who happens to be running a bleeding edge cluster, which wouldn't be supported anyway

/override ci/prow/verify-crd-schema
/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhadvig, JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [JoelSpeed]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/verify-crd-schema

In response to this:

This was added in #2163 last week. It hasn't hit a released version of the product yet, and as such, this is a compatible change that we can still make without worrying too much. Ratcheting validation would catch this for anyone who happens to be running a bleeding edge cluster, which wouldn't be supported anyway

/override ci/prow/verify-crd-schema
/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[jhadvig]

/label acknowledge-critical-fixes-only

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 3b362b0 and 2 for PR HEAD 806af1f in total

[jhadvig]

/override ci/prow/verify-crd-schema

[openshift-ci]

@jhadvig: jhadvig unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file, and the following github teams:openshift: openshift-release-oversight openshift-staff-engineers.

In response to this:

/override ci/prow/verify-crd-schema

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[JoelSpeed]

/override ci/prow/verify-crd-schema

[openshift-ci]

@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/verify-crd-schema

In response to this:

/override ci/prow/verify-crd-schema

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-ci]

@jhadvig: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-ci-robot]

@jhadvig: Jira Issue OCPBUGS-48740: Some pull requests linked via external trackers have merged:

• openshift/api#2163
• openshift/enhancements#1739

The following pull requests linked via external trackers have not merged:

• openshift/api#2164 is open

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-48740 has not been moved to the MODIFIED state.

In response to this:

Based on the conversation with @spadgett and @vojtechszocs we agreed we dont need the object-src directive as we thought and so we will remove it, until its need.

@assign @spadgett @JoelSpeed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-bot]

[ART PR BUILD NOTIFIER]

Distgit: ose-cluster-config-api
This PR has been included in build ose-cluster-config-api-container-v4.19.0-202501291837.p0.gb1a9b9a.assembly.stream.el9.
All builds following this will include this PR.

[openshift-cherrypick-robot]

@jhadvig: #2176 failed to apply on top of branch "release-4.18":

Applying: OCPBUGS-48740: Remove unnecessary object-src directive
Using index info to reconstruct a base tree...
M	console/v1/types_console_plugin.go
M	console/v1/zz_generated.crd-manifests/90_consoleplugins-CustomNoUpgrade.crd.yaml
M	console/v1/zz_generated.crd-manifests/90_consoleplugins-DevPreviewNoUpgrade.crd.yaml
M	console/v1/zz_generated.crd-manifests/90_consoleplugins-TechPreviewNoUpgrade.crd.yaml
M	console/v1/zz_generated.featuregated-crd-manifests/consoleplugins.console.openshift.io/ConsolePluginContentSecurityPolicy.yaml
M	console/v1/zz_generated.swagger_doc_generated.go
M	openapi/generated_openapi/zz_generated.openapi.go
M	openapi/openapi.json
Falling back to patching base and 3-way merge...
Auto-merging openapi/openapi.json
CONFLICT (content): Merge conflict in openapi/openapi.json
Auto-merging openapi/generated_openapi/zz_generated.openapi.go
CONFLICT (content): Merge conflict in openapi/generated_openapi/zz_generated.openapi.go
Auto-merging console/v1/zz_generated.swagger_doc_generated.go
CONFLICT (content): Merge conflict in console/v1/zz_generated.swagger_doc_generated.go
Auto-merging console/v1/zz_generated.featuregated-crd-manifests/consoleplugins.console.openshift.io/ConsolePluginContentSecurityPolicy.yaml
CONFLICT (content): Merge conflict in console/v1/zz_generated.featuregated-crd-manifests/consoleplugins.console.openshift.io/ConsolePluginContentSecurityPolicy.yaml
Auto-merging console/v1/zz_generated.crd-manifests/90_consoleplugins-TechPreviewNoUpgrade.crd.yaml
CONFLICT (content): Merge conflict in console/v1/zz_generated.crd-manifests/90_consoleplugins-TechPreviewNoUpgrade.crd.yaml
Auto-merging console/v1/zz_generated.crd-manifests/90_consoleplugins-DevPreviewNoUpgrade.crd.yaml
CONFLICT (content): Merge conflict in console/v1/zz_generated.crd-manifests/90_consoleplugins-DevPreviewNoUpgrade.crd.yaml
Auto-merging console/v1/zz_generated.crd-manifests/90_consoleplugins-CustomNoUpgrade.crd.yaml
CONFLICT (content): Merge conflict in console/v1/zz_generated.crd-manifests/90_consoleplugins-CustomNoUpgrade.crd.yaml
Auto-merging console/v1/types_console_plugin.go
CONFLICT (content): Merge conflict in console/v1/types_console_plugin.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 OCPBUGS-48740: Remove unnecessary object-src directive

In response to this:

/cherry-pick release-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[jhadvig]

please omit the last bot comment. I've accidentally tried to cherry-pick from commit.