Skip to content

MCO-1543: Update v1alpha1 MCN API #2201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ tests:
currentGeneration: 2
desiredGeneration: 1
expectedStatusError: "Invalid value: \"object\": desired generation must be greater than or equal to the current generation"
- name: PinnedImageSet desired generation must be greater than last failed generation
- name: PinnedImageSet desired generation must be greater than or equal to the last failed generation
initial: |
apiVersion: machineconfiguration.openshift.io/v1alpha1
kind: MachineConfigNode
Expand All @@ -179,7 +179,6 @@ tests:
- name: test-pinned-image-set
currentGeneration: 2
desiredGeneration: 2
lastFailedGeneration: 1
updated: |
apiVersion: machineconfiguration.openshift.io/v1alpha1
kind: MachineConfigNode
Expand All @@ -203,8 +202,8 @@ tests:
currentGeneration: 3
desiredGeneration: 3
lastFailedGeneration: 4
expectedStatusError: "Invalid value: \"object\": desired generation must be greater than last failed generation"
- name: PinnedImageSet desired generation must be set if last failed generation is set
expectedStatusError: "Invalid value: \"object\": desired generation must be greater than or equal to the last failed generation"
- name: PinnedImageSet last failed generation error must be defined on image pull and pin failure
initial: |
apiVersion: machineconfiguration.openshift.io/v1alpha1
kind: MachineConfigNode
Expand All @@ -225,6 +224,8 @@ tests:
desired: rendered-worker-abc
pinnedImageSets:
- name: test-pinned-image-set
currentGeneration: 2
desiredGeneration: 2
updated: |
apiVersion: machineconfiguration.openshift.io/v1alpha1
kind: MachineConfigNode
Expand All @@ -245,5 +246,7 @@ tests:
desired: rendered-worker-abc
pinnedImageSets:
- name: test-pinned-image-set
lastFailedGeneration: 2
expectedStatusError: "Invalid value: \"object\": desired generation must be defined if last failed generation is defined"
currentGeneration: 2
desiredGeneration: 3
lastFailedGeneration: 3
expectedStatusError: "Invalid value: \"object\": last failed generation error must be defined on image pull and pin failure"
143 changes: 80 additions & 63 deletions machineconfiguration/v1alpha1/types_machineconfignode.go

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

9 changes: 1 addition & 8 deletions machineconfiguration/v1alpha1/zz_generated.deepcopy.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
machineconfignodes.machineconfiguration.openshift.io:
Annotations: {}
ApprovedPRNumber: https://github.com/openshift/api/pull/1596
ApprovedPRNumber: https://github.com/openshift/api/pull/2201
CRDName: machineconfignodes.machineconfiguration.openshift.io
Capability: ""
Category: ""
Expand Down Expand Up @@ -48,10 +48,6 @@ machineconfignodes.machineconfiguration.openshift.io:
name: Resumed
priority: 1
type: string
- jsonPath: .status.conditions[?(@.type=="UpdateCompatible")].status
name: UpdateCompatible
priority: 1
type: string
- jsonPath: .status.conditions[?(@.type=="AppliedFilesAndOS")].status
name: UpdatedFilesAndOS
priority: 1
Expand All @@ -68,10 +64,6 @@ machineconfignodes.machineconfiguration.openshift.io:
name: RebootedNode
priority: 1
type: string
- jsonPath: .status.conditions[?(@.type=="ReloadedCRIO")].status
name: ReloadedCRIO
priority: 1
type: string
- jsonPath: .status.conditions[?(@.type=="Uncordoned")].status
name: UncordonedNode
priority: 1
Expand Down

Large diffs are not rendered by default.

47 changes: 26 additions & 21 deletions machineconfiguration/v1alpha1/zz_generated.swagger_doc_generated.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading