Skip to content

[release-4.18] Promote AddtionalRoutingCapabilities feature gate to default feature set #2226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

jcaamano
Copy link
Contributor

No description provided.

…efault feature set

Signed-off-by: Jaime Caamaño Ruiz <[email protected]>
Copy link
Contributor

openshift-ci bot commented Mar 12, 2025

Hello @jcaamano! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@jcaamano
Copy link
Contributor Author

/hold

@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Mar 12, 2025
@openshift-ci openshift-ci bot requested review from deads2k and sjenning March 12, 2025 14:11
Copy link
Contributor

openshift-ci bot commented Mar 12, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jcaamano
Once this PR has been reviewed and has the lgtm label, please assign sjenning for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

openshift-ci bot commented Mar 12, 2025

@jcaamano: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn 313100b link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-aws-serial 313100b link true /test e2e-aws-serial
ci/prow/verify-crd-schema 313100b link true /test verify-crd-schema
ci/prow/verify 313100b link true /test verify
ci/prow/e2e-aws-ovn-hypershift 313100b link true /test e2e-aws-ovn-hypershift
ci/prow/integration 313100b link true /test integration

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jcaamano
Copy link
Contributor Author

/close

in favor of the much older #2119 which I didn't realize it was already there

@openshift-ci openshift-ci bot closed this Mar 31, 2025
Copy link
Contributor

openshift-ci bot commented Mar 31, 2025

@jcaamano: Closed this PR.

In response to this:

/close

in favor of the much older #2119 which I didn't realize it was already there

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant