OCPBUGS-34194: Modify api description for join, transit and masquerade subnets #2320
Conversation
|
Hello @arghosh93! Some important instructions when contributing to openshift/api: |
openshift-ci
bot
added
the
size/L
arghosh93
changed the title
openshift-ci-robot
added
jira/severity-moderate
|
@arghosh93: This pull request references Jira Issue OCPBUGS-34194, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
| @@ -646,7 +646,7 @@ type IPv4GatewayConfig struct { | |||
| // OVN-Kubernetes as well as other networks used on the host. Additionally the subnet must | |||
| // be large enough to accommodate 6 IPs (maximum prefix length /29). | |||
| // When omitted, this means no opinion and the platform is left to choose a reasonable default which is subject to change over time. | |||
| // The current default subnet is 169.254.169.0/29 | |||
| // The current default subnet is 169.254.0.0/17 | |||
There was a problem hiding this comment.
wait a sec, did we change it on the API level?
Did we do it such that older clusters continue to have /29 as default but new ones would have /17? can you please jog my memory with that CNO PR that explained this?
There was a problem hiding this comment.
CNO does not change masquerade subnet for clusters which are being upgraded. New 4.17 clusters gets new default subnet. If UDN must be used in upgraded cluster then masquerade subnet must be changed at day 2.
openshift/cluster-network-operator@64ce003
can you also provide link to the JIRA epics in the PR description for history of when this change was performed and how far we need to backport this? |
Join and transit switch subnets can be configured at day 2 now and this commit is to modify api description for InternalJoinSubnet and InternalTransitSwitchSubnet to reflect recent changes. Signed-off-by: Arnab Ghosh <[email protected]>
Default masquerade subnet has been changed recently and modifying api description to reflect recent changes. Signed-off-by: Arnab Ghosh <[email protected]>
arghosh93
force-pushed
the
OCPBUGS-34194-new
branch
from
390cd55 to
6e35e96
Compare
|
/jira refresh |
openshift-ci-robot
added
jira/valid-bug
|
@arghosh93: This pull request references Jira Issue OCPBUGS-34194, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@arghosh93: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/approve This is fine but needs networking to clarify the changed subnets /assign @tssurya |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: arghosh93, JoelSpeed The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Join and transit switch subnets can be configured at day 2 now and this commit is to modify api description for InternalJoinSubnet and InternalTransitSwitchSubnet to reflect recent changes.
Default masquerade subnet has also been changed recently and modifying api description to reflect recent changes.
Task which introduced the capability to change Transit and join subnet at day 2: https://issues.redhat.com/browse/CORENET-4604
This changes have been backported till 4.14.
Task which introduced capability to change masquerade subnet at day 2 : https://issues.redhat.com/browse/CORENET-4999
This is supported from 4.17 onward