-
Notifications
You must be signed in to change notification settings - Fork 541
CORS-4041: Remove the TagManager from the GCP Custom Endpoints #2323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
** The tag manager or tagging does appear to have a service in GCP, but this particular one is NOT used. Instead openshift uses the cloud resource manager service, so there is no need to support Tag Manager.
@barbacbd: This pull request references CORS-4041 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Hello @barbacbd! Some important instructions when contributing to openshift/api: |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: barbacbd The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cc @JoelSpeed |
@barbacbd: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When did this API ship initially? What is happening in the cluster today for folks who already specify this value? What will happen when we drop support? Do you have any idea how many people this change might affect?
@@ -630,7 +630,7 @@ const ( | |||
) | |||
|
|||
// GCPServiceEndpointName is the name of the GCP Service Endpoint. | |||
// +kubebuilder:validation:Enum=Compute;Container;CloudResourceManager;DNS;File;IAM;ServiceUsage;Storage;TagManager | |||
// +kubebuilder:validation:Enum=Compute;Container;CloudResourceManager;DNS;File;IAM;ServiceUsage;Storage |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What happens to existing resources when you remove this value? This API has shipped so to be able to remove a value we would need to be certain that it won't break existing resources.
Can you please add a ratcheting validation test (see tests/README.md
) to make sure this change will allow existing resources with this value set to:
- Update the field itself to remove the bad value
- Update the field value to add a new value
- Update other fields around the field while leaving an invalid value in place
** The tag manager or tagging does appear to have a service in GCP, but this particular one is NOT used. Instead openshift uses the cloud resource manager service, so there is no need to support Tag Manager.