Skip to content

OCPBUGS-56382: Fix validation for Resource field in MOSB API #2327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

OCPBUGS-56382: Fix validation for Resource field in MOSB API #2327

wants to merge 1 commit into from
+48 −39

Conversation

umohnani8
Copy link
Contributor

Fix the validation for the Resource field in the MOSB API to be of dns1035Label.

Fixes https://issues.redhat.com/browse/OCPBUGS-56382

@umohnani8
Fix validation for Resource field in MOSB API
7065a4e 
Fix the validation for the Resource field in the MOSB API
to be of dns1035Label.

Signed-off-by: Urvashi <[email protected]>
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels May 16, 2025
@openshift-ci-robot
Copy link

@umohnani8: This pull request references Jira Issue OCPBUGS-56382, which is invalid:

  • expected the bug to target either version "4.20." or "openshift-4.20.", but it targets "4.19.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Fix the validation for the Resource field in the MOSB API to be of dns1035Label.

Fixes https://issues.redhat.com/browse/OCPBUGS-56382

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 16, 2025

Hello @umohnani8! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@umohnani8
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot
Copy link

@umohnani8: This pull request references Jira Issue OCPBUGS-56382, which is invalid:

  • expected the bug to target either version "4.20." or "openshift-4.20.", but it targets "4.19.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 16, 2025
@openshift-ci openshift-ci bot requested review from deads2k and sinnykumari May 16, 2025 14:32
@umohnani8
Copy link
Contributor Author

/jira refresh

@JoelSpeed
Copy link
Contributor

/lgtm

Thanks for the quick fix, it's important we get this backported into 4.19 as well

@JoelSpeed
Copy link
Contributor

/cherry-pick release-4.19

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels May 16, 2025
@openshift-cherrypick-robot
Copy link

@JoelSpeed: once the present PR merges, I will cherry-pick it on top of release-4.19 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci-robot
Copy link

@umohnani8: This pull request references Jira Issue OCPBUGS-56382, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.20.0) matches configured target version for branch (4.20.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 16, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 16, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed, umohnani8

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 16, 2025
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 0154a4f and 2 for PR HEAD 7065a4e in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 094c670 and 1 for PR HEAD 7065a4e in total

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 17, 2025

@umohnani8: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-serial-techpreview-2of2 7065a4e link true /test e2e-aws-serial-techpreview-2of2

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 094c670 and 2 for PR HEAD 7065a4e in total

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deads2k deads2k Awaiting requested review from deads2k

@sinnykumari sinnykumari Awaiting requested review from sinnykumari

Assignees

@JoelSpeed JoelSpeed

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@umohnani8 @openshift-ci-robot @JoelSpeed @openshift-cherrypick-robot