-
Notifications
You must be signed in to change notification settings - Fork 796
MON-4607: add zoneinfo to NodeExporterCollectorConfig CRD types #2948
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -466,6 +466,14 @@ type NodeExporterCollectorConfig struct { | |||||
| // Enable when you need visibility into kernel softirq processing across CPUs. | ||||||
| // +optional | ||||||
| Softirqs NodeExporterCollectorSoftirqsConfig `json:"softirqs,omitempty,omitzero"` | ||||||
| // zoneinfo configures the zoneinfo collector, which exposes per-zone memory page counts, | ||||||
| // watermarks, and protection thresholds from /proc/zoneinfo. | ||||||
| // zoneinfo is optional. | ||||||
| // When omitted, this means no opinion and the platform is left to choose a reasonable default, | ||||||
| // which is subject to change over time. The current default is disabled. | ||||||
| // Enable when you need visibility into kernel memory zone allocation and pressure. | ||||||
| // +optional | ||||||
| Zoneinfo NodeExporterCollectorZoneinfoConfig `json:"zoneinfo,omitempty,omitzero"` | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Nit, omitempty is superfluous
Suggested change
|
||||||
| } | ||||||
|
|
||||||
| // NodeExporterCollectorCpufreqConfig provides configuration for the cpufreq collector | ||||||
|
|
@@ -689,6 +697,20 @@ type NodeExporterCollectorSoftirqsConfig struct { | |||||
| CollectionPolicy NodeExporterCollectorCollectionPolicy `json:"collectionPolicy,omitempty"` | ||||||
| } | ||||||
|
|
||||||
| // NodeExporterCollectorZoneinfoConfig provides configuration for the zoneinfo collector | ||||||
| // of the node-exporter agent. The zoneinfo collector exposes per-zone memory page counts, | ||||||
| // watermarks, and protection thresholds from /proc/zoneinfo. | ||||||
| // It is disabled by default. | ||||||
| type NodeExporterCollectorZoneinfoConfig struct { | ||||||
| // collectionPolicy declares whether the zoneinfo collector collects metrics. | ||||||
| // This field is required. | ||||||
| // Valid values are "Collect" and "DoNotCollect". | ||||||
| // When set to "Collect", the zoneinfo collector is active and zone memory statistics are collected. | ||||||
| // When set to "DoNotCollect", the zoneinfo collector is inactive. | ||||||
| // +required | ||||||
| CollectionPolicy NodeExporterCollectorCollectionPolicy `json:"collectionPolicy,omitempty"` | ||||||
| } | ||||||
|
|
||||||
| // MonitoringPluginConfig provides configuration options for the monitoring plugin | ||||||
| // that runs as a dynamic plugin of the OpenShift web console. | ||||||
| // The monitoring plugin provides the monitoring UI in the OpenShift web console | ||||||
|
|
||||||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Disabled isn't actually an option here, so I think this godoc is out of date