Skip to content

Conversation

@andfasano
Copy link
Contributor

This patch fixes the issue of loading the extra manifests generated by the appliance when the cluster is created by the UI. This step is necessary to ensure the correct installation of the selected OLM operators.

Requires #375

@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 29, 2025

@andfasano: This pull request references MGMT-20521 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.19.0" version, but no target version was set.

Details

In response to this:

This patch fixes the issue of loading the extra manifests generated by the appliance when the cluster is created by the UI. This step is necessary to ensure the correct installation of the selected OLM operators.

Requires #375

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 29, 2025
@andfasano
Copy link
Contributor Author

cc @danielerez

@openshift-ci openshift-ci bot requested review from danielerez and romfreiman April 29, 2025 17:51
@openshift-ci
Copy link

openshift-ci bot commented Apr 29, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: andfasano
Once this PR has been reviewed and has the lgtm label, please assign oourfali for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@bfournie
Copy link

bfournie commented May 1, 2025

/lgtm
I confirmed that the extra manifests are now included in the cluster, for example:

$ oc describe operatorhub -A
Name:         cluster
Namespace:    
Labels:       <none>
Annotations:  <none>
API Version:  config.openshift.io/v1
Kind:         OperatorHub
Metadata:
  Creation Timestamp:  2025-05-01T21:17:44Z
  Generation:          1
  Resource Version:    32529
  UID:                 d016362f-5100-4c37-a9ae-1bf4a022c903
Spec:
  Disable All Default Sources:  true
Status:
  Sources:
    Disabled:  true
    Name:      community-operators
    Status:    Success
    Disabled:  true
    Name:      redhat-marketplace
    Status:    Success
    Disabled:  true
    Name:      redhat-operators
    Status:    Success
    Disabled:  true
    Name:      certified-operators
    Status:    Success
Events:        <none>

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 1, 2025
@danielerez
Copy link
Contributor

/retest

echo "Fetched cluster-id: $cluster_id"

# Load extra manifests, if present.,Required only for the interactive workflow
if [[ "$WORKFLOW_TYPE" == "install-interactive-disconnected" ]]; then
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already have the 'EnableInteractiveFlow' flag that can be used. Be can be done in a separate PR.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Handled by: #380

@openshift-ci
Copy link

openshift-ci bot commented May 4, 2025

@andfasano: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-sno-dualstack-dhcp acab217 link false /test e2e-sno-dualstack-dhcp
ci/prow/e2e-compact-ipv4-static acab217 link true /test e2e-compact-ipv4-static

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@danielerez danielerez merged commit a352b36 into openshift:master May 4, 2025
3 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants