-
Notifications
You must be signed in to change notification settings - Fork 39
MGMT-20521: Load extra manifests on cluster startup #377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@andfasano: This pull request references MGMT-20521 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.19.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
cc @danielerez |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: andfasano The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
a8b81be to
acab217
Compare
|
/lgtm |
|
/retest |
| echo "Fetched cluster-id: $cluster_id" | ||
|
|
||
| # Load extra manifests, if present.,Required only for the interactive workflow | ||
| if [[ "$WORKFLOW_TYPE" == "install-interactive-disconnected" ]]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We already have the 'EnableInteractiveFlow' flag that can be used. Be can be done in a separate PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Handled by: #380
|
@andfasano: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This patch fixes the issue of loading the extra manifests generated by the appliance when the cluster is created by the UI. This step is necessary to ensure the correct installation of the selected OLM operators.
Requires #375