AGENT-1313: Add IRI manifest for OVE #612
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@pawanpinjarkar: This pull request references AGENT-1364 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.21.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
requested review from
andfasano,
avishayt,
danielerez and
oourfali
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: pawanpinjarkar The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
pawanpinjarkar
force-pushed
the
add-irr-file-ove
branch
from
a59b52a to
466c2a2
Compare
| if len(parts) >= 2 { | ||
| version = parts[len(parts)-1] | ||
| } | ||
| } |
There was a problem hiding this comment.
This sounds like a piece of code that could deserve its own function, ie something like getCurrentOpenShiftVersion() ?
pawanpinjarkar
force-pushed
the
add-irr-file-ove
branch
from
466c2a2 to
ef85f7b
Compare
| - name: ocp-release-bundle-%s | ||
| `, version) | ||
|
|
||
| irrFile := ignition.FileFromString("/etc/assisted/manifests/internalreleaseimage.yaml", "root", 0644, irrContent) |
There was a problem hiding this comment.
| irrFile := ignition.FileFromString("/etc/assisted/manifests/internalreleaseimage.yaml", "root", 0644, irrContent) | |
| iriFile := ignition.FileFromString("/etc/assisted/manifests/internalreleaseimage.yaml", "root", 0644, irrContent) |
pawanpinjarkar
changed the title
pawanpinjarkar
force-pushed
the
add-irr-file-ove
branch
from
1016d24 to
bab183c
Compare
pawanpinjarkar
force-pushed
the
add-irr-file-ove
branch
from
bab183c to
6d8ad39
Compare
|
@pawanpinjarkar: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/hold Before landing this PR we'll need to test the integration of openshift/machine-config-operator#5452 with @danielerez work (ie #613) |
openshift-ci
bot
added
the
do-not-merge/hold
pawanpinjarkar
changed the title
|
@pawanpinjarkar: This pull request references AGENT-1313 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-merge-robot
added
the
needs-rebase
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
4 participants
Adds InternalReleaseImage resource manifest for OVE