Skip to content

ACM-19143: align default osImages for 2.13 with supported-ocp-versions #7469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: release-ocm-2.13
Choose a base branch
from
Open

ACM-19143: align default osImages for 2.13 with supported-ocp-versions #7469

wants to merge 1 commit into from

Conversation

zszabo-rh
Copy link
Contributor

@zszabo-rh zszabo-rh commented Mar 27, 2025 •
edited
Loading

ACM-19143: default osImages versions should be taken from supported-ocp-versions.json
Pls note that corresponding backplane version is 5 versions behind release-ocm version.

Main changes:

  1. data/default_os_images.json was modified (+ "make generate")
  2. Necessary subsystem test modifications.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 27, 2025 •
edited by openshift-ci bot
Loading

@zszabo-rh: This pull request references ACM-19143 which is a valid jira issue.

In response to this:

ACM-19143: default osImages versions should be taken from supported-ocp-versions.json
Pls note that corresponding backplane version is 5 versions behind release-ocm version.

data/default_os_images.json was modified, all other changes were generated.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 27, 2025
@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 27, 2025
@openshift-ci openshift-ci bot requested review from gamli75 and rccrdpccl March 27, 2025 10:03
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Mar 27, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: zszabo-rh
Once this PR has been reviewed and has the lgtm label, please assign romfreiman for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zszabo-rh
Copy link
Contributor Author

/retest

1 similar comment
@zszabo-rh
Copy link
Contributor Author

/retest

@codecov Codecov
Copy link

codecov bot commented Mar 27, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.00%. Comparing base (093b510) to head (89357c5).
Report is 6 commits behind head on release-ocm-2.13.

Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                  @@
##           release-ocm-2.13    #7469      +/-   ##
====================================================
+ Coverage             67.97%   68.00%   +0.02%     
====================================================
  Files                   300      300              
  Lines                 41031    41072      +41     
====================================================
+ Hits                  27891    27929      +38     
- Misses                10635    10637       +2     
- Partials               2505     2506       +1

see 7 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@zszabo-rh
Copy link
Contributor Author

/retest

2 similar comments
@zszabo-rh
Copy link
Contributor Author

/retest

@zszabo-rh
Copy link
Contributor Author

/retest

@zszabo-rh zszabo-rh force-pushed the release-ocm-2.13 branch 2 times, most recently from 388fb4c to ff4df3e Compare March 28, 2025 13:25
@openshift-ci openshift-ci bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 28, 2025
@zszabo-rh zszabo-rh force-pushed the release-ocm-2.13 branch 3 times, most recently from 31b8b47 to 813e83c Compare March 31, 2025 11:02
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 1, 2025 •
edited by openshift-ci bot
Loading

@zszabo-rh: This pull request references ACM-19143 which is a valid jira issue.

In response to this:

ACM-19143: default osImages versions should be taken from supported-ocp-versions.json
Pls note that corresponding backplane version is 5 versions behind release-ocm version.

Commits:

  1. Main changes: data/default_os_images.json was modified, all other changes were generated.
  2. Necessary unit and subsystem tst modifications.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Apr 1, 2025
@openshift-ci openshift-ci bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 1, 2025
@zszabo-rh zszabo-rh force-pushed the release-ocm-2.13 branch 4 times, most recently from 681ca03 to 5725e93 Compare April 3, 2025 05:32
@zszabo-rh
Copy link
Contributor Author

/test subsystem-aws

@zszabo-rh
Copy link
Contributor Author

/test subsystem-aws

@zszabo-rh zszabo-rh closed this Apr 8, 2025
@zszabo-rh zszabo-rh reopened this Apr 10, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 10, 2025 •
edited by openshift-ci bot
Loading

@zszabo-rh: This pull request references ACM-19143 which is a valid jira issue.

In response to this:

ACM-19143: default osImages versions should be taken from supported-ocp-versions.json
Pls note that corresponding backplane version is 5 versions behind release-ocm version.

Commits:

  1. Main changes: data/default_os_images.json was modified, all other changes were generated.
  2. Necessary unit and subsystem test modifications.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@zszabo-rh
Copy link
Contributor Author

/test subsystem-aws subsystem-kubeapi-aws

@zszabo-rh
Copy link
Contributor Author

/test subsystem-aws

@openshift-ci openshift-ci bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 11, 2025
@zszabo-rh
Copy link
Contributor Author

/test all

@zszabo-rh
Copy link
Contributor Author

/test all

@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 11, 2025 •
edited by openshift-ci bot
Loading

@zszabo-rh: This pull request references ACM-19143 which is a valid jira issue.

In response to this:

ACM-19143: default osImages versions should be taken from supported-ocp-versions.json
Pls note that corresponding backplane version is 5 versions behind release-ocm version.

Main changes:

  1. data/default_os_images.json was modified (+ "make generate")
  2. Necessary subsystem test modifications.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@zszabo-rh
Copy link
Contributor Author

/test e2e-ai-operator-ztp

2 similar comments
@zszabo-rh
Copy link
Contributor Author

/test e2e-ai-operator-ztp

@zszabo-rh
Copy link
Contributor Author

/test e2e-ai-operator-ztp

@zszabo-rh zszabo-rh marked this pull request as ready for review April 15, 2025 12:36
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 15, 2025
@openshift-ci openshift-ci bot requested a review from adriengentil April 15, 2025 12:38
@zszabo-rh
Copy link
Contributor Author

/retest

2 similar comments
@zszabo-rh
Copy link
Contributor Author

/retest

@zszabo-rh
Copy link
Contributor Author

/retest

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Apr 24, 2025

@zszabo-rh: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@zszabo-rh zszabo-rh requested a review from carbonin April 25, 2025 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gamli75 gamli75 Awaiting requested review from gamli75

@rccrdpccl rccrdpccl Awaiting requested review from rccrdpccl

@adriengentil adriengentil Awaiting requested review from adriengentil

@carbonin carbonin Awaiting requested review from carbonin

Assignees
No one assigned
Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zszabo-rh @openshift-ci-robot @carbonin