ACM-19143: remove obsolete image versions #7511
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@zszabo-rh: This pull request references ACM-19143 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
openshift-ci
bot
added
the
size/XL
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: zszabo-rh The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test subsystem-aws |
|
@zszabo-rh: The specified target(s) for The following commands are available to trigger optional jobs: Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test edge-subsystem-kubeapi-aws edge-subsystem-aws |
zszabo-rh
force-pushed
the
reduce_number_of_images
branch
from
71c63a5 to
4b875db
Compare
|
/test edge-subsystem-kubeapi-aws |
zszabo-rh
force-pushed
the
reduce_number_of_images
branch
from
4b875db to
ead0073
Compare
|
/retest |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7511 +/- ##
==========================================
- Coverage 67.30% 67.30% -0.01%
==========================================
Files 334 334
Lines 42299 42299
==========================================
- Hits 28470 28468 -2
- Misses 11257 11258 +1
- Partials 2572 2573 +1 🚀 New features to boost your workflow:
|
|
/test edge-subsystem-kubeapi-aws edge-subsystem-aws |
zszabo-rh
force-pushed
the
reduce_number_of_images
branch
2 times, most recently
from
bfe8991 to
11927d5
Compare
|
/test edge-subsystem-kubeapi-aws edge-subsystem-aws |
zszabo-rh
force-pushed
the
reduce_number_of_images
branch
from
11927d5 to
ee812fc
Compare
|
/test edge-subsystem-kubeapi-aws edge-subsystem-aws |
zszabo-rh
force-pushed
the
reduce_number_of_images
branch
from
ee812fc to
e6df9cd
Compare
|
/test edge-subsystem-kubeapi-aws edge-subsystem-aws |
zszabo-rh
force-pushed
the
reduce_number_of_images
branch
from
e6df9cd to
2ec4cdf
Compare
|
/test all |
zszabo-rh
force-pushed
the
reduce_number_of_images
branch
from
2ec4cdf to
8619025
Compare
openshift-ci
bot
added
size/XXL
|
/test all |
zszabo-rh
force-pushed
the
reduce_number_of_images
branch
from
8619025 to
af0240b
Compare
|
/test all |
zszabo-rh
force-pushed
the
reduce_number_of_images
branch
from
af0240b to
e6f03c1
Compare
|
/test all |
zszabo-rh
force-pushed
the
reduce_number_of_images
branch
from
e6f03c1 to
8259224
Compare
|
/test edge-subsystem-aws |
…ocp-versions.json
zszabo-rh
force-pushed
the
reduce_number_of_images
branch
from
8259224 to
956159f
Compare
|
/test edge-subsystem-aws |
|
@zszabo-rh: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
| @@ -32,7 +34,7 @@ import ( | |||
| var log *logrus.Logger | |||
| var wiremock *utils_test.WireMock | |||
| var kubeClient k8sclient.Client | |||
| var VipAutoAllocOpenshiftVersion string = "4.14.0" | |||
There was a problem hiding this comment.
Lets avoid setting version here, only get it dynamically
There was a problem hiding this comment.
it's a deleted line :)
| var openshiftVersionLong string = "4.11.59" | ||
| var openshiftVersion string = "4.11" | ||
| var snoVersion string = "4.11" | ||
| var multiarchOpenshiftVersion string = "4.11.0-multi" |
There was a problem hiding this comment.
what are these still used for ? 4.11 is not available anymore no ?
There was a problem hiding this comment.
sure, the initial value could be anything, I intentionally kept 4.11 just to see if it really gets overridden by an existing image version.
|
Closed as currently there is no way to separate ACM and SaaS related changes in master. |
ACM-19143: default osImages versions should be taken from supported-ocp-versions.json
Pls note that corresponding backplane version is 5 versions behind release-ocm version.
Main changes: