MGMT-20233: Recompute operator dependencies after discovering the hosts

[pastequo]

Reopening #7227

cc @jhernand

Also adding

• Write DB changes in one transaction
• Add call to EnsureOperatorPrerequisite after the operator list is updated

At first I added some logic to

• Reset auto-assign roles if anything changed

but I removed it since it's already done in the HostStateMonitor

List all the issues related to this PR

• New Feature
• Enhancement
• Bug fix
• Tests
• Documentation
• CI/CD

What environments does this code impact?

• Automation (CI, tools, etc)
• Cloud
• Operator Managed Deployments
• None

How was this code tested?

• assisted-test-infra environment
• dev-scripts environment
• Reviewer's test appreciated
• Waiting for CI to do a full test run
• Manual (Elaborate on how it was tested)
• No tests needed

Was tested locally with others changes to have a single openshift AI bundle that add/remove nvidia or amd operator based on the host inventory during the discovery

Checklist

• Title and description added to both, commit and PR.
• Relevant issues have been associated (see CONTRIBUTING guide)
• This change does not require a documentation update (docstring, docs, README, etc)
• Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

• Are the title and description (in both PR and commit) meaningful and clear?
• Is there a bug required (and linked) for this change?
• Should this PR be backported?

[openshift-ci-robot]

@pastequo: This pull request references MGMT-20233 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.19.0" version, but no target version was set.

In response to this:

Reopening #7227

cc @jhernand

Also adding

• Write DB changes in one transaction
• Add call to EnsureOperatorPrerequisite after the operator list is updated
• Reset auto-assign roles if anything changed

List all the issues related to this PR

• New Feature
• Enhancement
• Bug fix
• Tests
• Documentation
• CI/CD

What environments does this code impact?

• Automation (CI, tools, etc)
• Cloud
• Operator Managed Deployments
• None

How was this code tested?

• assisted-test-infra environment
• dev-scripts environment
• Reviewer's test appreciated
• Waiting for CI to do a full test run
• Manual (Elaborate on how it was tested)
• No tests needed

Was tested locally with others changes to have a single openshift AI bundle that add/remove nvidia or amd operator based on the host inventory during the discovery

Checklist

• Title and description added to both, commit and PR.
• Relevant issues have been associated (see CONTRIBUTING guide)
• This change does not require a documentation update (docstring, docs, README, etc)
• Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

• Are the title and description (in both PR and commit) meaningful and clear?
• Is there a bug required (and linked) for this change?
• Should this PR be backported?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pastequo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [pastequo]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[codecov]

Codecov Report

Attention: Patch coverage is 40.67797% with 70 lines in your changes missing coverage. Please review.

Project coverage is 67.87%. Comparing base (7e3ad83) to head (a34aedc).
Report is 24 commits behind head on master.

Files with missing lines	Patch %	Lines
internal/cluster/refresh_status_preprocessor.go	40.36%	50 Missing and 15 partials ⚠️
internal/operators/common/common.go	0.00%	5 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #7524      +/-   ##
==========================================
+ Coverage   67.29%   67.87%   +0.57%     
==========================================
  Files         334      335       +1     
  Lines       42293    43541    +1248     
==========================================
+ Hits        28461    29553    +1092     
- Misses      11258    11392     +134     
- Partials     2574     2596      +22     

Files with missing lines	Coverage Δ
internal/bminventory/inventory.go	71.57% <ø> (ø)
internal/cluster/cluster.go	65.56% <100.00%> (ø)
internal/operators/manager.go	79.09% <100.00%> (ø)
internal/operators/common/common.go	22.38% <0.00%> (-1.81%)	⬇️
internal/cluster/refresh_status_preprocessor.go	70.08% <40.36%> (-24.25%)	⬇️

... and 14 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[pastequo]

/retest

[pastequo]

/retest-required

[pastequo]

/retest-required

[openshift-ci-robot]

@pastequo: This pull request references MGMT-20233 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.19.0" version, but no target version was set.

In response to this:

Reopening #7227

cc @jhernand

Also adding

• Write DB changes in one transaction
• Add call to EnsureOperatorPrerequisite after the operator list is updated

At first I added some logic to

• Reset auto-assign roles if anything changed
  but I removed it since it's already done in the HostStateMonitor

List all the issues related to this PR

• New Feature
• Enhancement
• Bug fix
• Tests
• Documentation
• CI/CD

What environments does this code impact?

• Automation (CI, tools, etc)
• Cloud
• Operator Managed Deployments
• None

How was this code tested?

• assisted-test-infra environment
• dev-scripts environment
• Reviewer's test appreciated
• Waiting for CI to do a full test run
• Manual (Elaborate on how it was tested)
• No tests needed

Was tested locally with others changes to have a single openshift AI bundle that add/remove nvidia or amd operator based on the host inventory during the discovery

Checklist

• Title and description added to both, commit and PR.
• Relevant issues have been associated (see CONTRIBUTING guide)
• This change does not require a documentation update (docstring, docs, README, etc)
• Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

• Are the title and description (in both PR and commit) meaningful and clear?
• Is there a bug required (and linked) for this change?
• Should this PR be backported?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@pastequo: This pull request references MGMT-20233 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.19.0" version, but no target version was set.

In response to this:

Reopening #7227

cc @jhernand

Also adding

• Write DB changes in one transaction
• Add call to EnsureOperatorPrerequisite after the operator list is updated

At first I added some logic to

• Reset auto-assign roles if anything changed

but I removed it since it's already done in the HostStateMonitor

List all the issues related to this PR

• New Feature
• Enhancement
• Bug fix
• Tests
• Documentation
• CI/CD

What environments does this code impact?

• Automation (CI, tools, etc)
• Cloud
• Operator Managed Deployments
• None

How was this code tested?

• assisted-test-infra environment
• dev-scripts environment
• Reviewer's test appreciated
• Waiting for CI to do a full test run
• Manual (Elaborate on how it was tested)
• No tests needed

Was tested locally with others changes to have a single openshift AI bundle that add/remove nvidia or amd operator based on the host inventory during the discovery

Checklist

• Title and description added to both, commit and PR.
• Relevant issues have been associated (see CONTRIBUTING guide)
• This change does not require a documentation update (docstring, docs, README, etc)
• Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

• Are the title and description (in both PR and commit) meaningful and clear?
• Is there a bug required (and linked) for this change?
• Should this PR be backported?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[pastequo]

/retest

[pastequo]

/retest-required

[pastequo]

/retest-required

[pastequo]

/retest-required

[pastequo]

/retest-required

[pastequo]

/retest-required

[jhernand]

/lgtm

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 31a16a4 and 2 for PR HEAD a34aedc in total

[pastequo]

/retest-required

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 31a16a4 and 2 for PR HEAD a34aedc in total

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 6125d3d and 1 for PR HEAD a34aedc in total

[pastequo]

/retest

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD d222e13 and 0 for PR HEAD a34aedc in total

[pastequo]

/retest-required

[openshift-ci-robot]

/hold

Revision a34aedc was retested 3 times: holding

[pastequo]

/retest

[pastequo]

/unhold

[openshift-ci]

@pastequo: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/okd-scos-e2e-aws-ovn	a34aedc	link	false	/test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.