MGMT-20369: retrieve stream-coreos image instead of rhel-coreos when installing OKD

[rccrdpccl]

OKD doesn't use rhel-coreos, it uses stream-coreos instead

List all the issues related to this PR

• New Feature
• Enhancement
• Bug fix
• Tests
• Documentation
• CI/CD

What environments does this code impact?

• Automation (CI, tools, etc)
• Cloud
• Operator Managed Deployments
• None

How was this code tested?

• assisted-test-infra environment
• dev-scripts environment
• Reviewer's test appreciated
• Waiting for CI to do a full test run
• Manual (Elaborate on how it was tested)
• No tests needed

Checklist

• Title and description added to both, commit and PR.
• Relevant issues have been associated (see CONTRIBUTING guide)
• This change does not require a documentation update (docstring, docs, README, etc)
• Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

• Are the title and description (in both PR and commit) meaningful and clear?
• Is there a bug required (and linked) for this change?
• Should this PR be backported?

[openshift-ci-robot]

@rccrdpccl: This pull request references MGMT-20369 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.19.0" version, but no target version was set.

Details

In response to this:

OKD doesn't use rhel-coreos, it uses stream-coreos instead

List all the issues related to this PR

• New Feature
• Enhancement
• Bug fix
• Tests
• Documentation
• CI/CD

What environments does this code impact?

• Automation (CI, tools, etc)
• Cloud
• Operator Managed Deployments
• None

How was this code tested?

• assisted-test-infra environment
• dev-scripts environment
• Reviewer's test appreciated
• Waiting for CI to do a full test run
• Manual (Elaborate on how it was tested)
• No tests needed

Checklist

• Title and description added to both, commit and PR.
• Relevant issues have been associated (see CONTRIBUTING guide)
• This change does not require a documentation update (docstring, docs, README, etc)
• Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

• Are the title and description (in both PR and commit) meaningful and clear?
• Is there a bug required (and linked) for this change?
• Should this PR be backported?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[rccrdpccl]

/cc @jianzzha

[openshift-ci]

@rccrdpccl: GitHub didn't allow me to request PR reviews from the following users: jianzzha.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

/cc @jianzzha

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[rccrdpccl]

/retest

[codecov]

Codecov Report

Attention: Patch coverage is 75.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 67.30%. Comparing base (abd0143) to head (9a1128d).
Report is 25 commits behind head on master.

Files with missing lines	Patch %	Lines
internal/oc/release.go	75.00%	4 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #7534      +/-   ##
==========================================
- Coverage   67.30%   67.30%   -0.01%     
==========================================
  Files         334      335       +1     
  Lines       42299    42486     +187     
==========================================
+ Hits        28470    28595     +125     
- Misses      11257    11306      +49     
- Partials     2572     2585      +13     

Files with missing lines	Coverage Δ
internal/oc/release.go	75.45% <75.00%> (+2.06%)	⬆️

... and 17 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[rccrdpccl]

/hold

[rccrdpccl]

/unhold
/retest

[rccrdpccl]

/retest

[carbonin]

Is this consistent with how we're checking for OKD in other places? I remember seeing a check somewhere but I don't know how it's implemented.

[rccrdpccl]

I cannot find any other parts where we check for OKD, apart from the OKD-RPMS image (which I think it's not really equivalent to this). Alternatively we could just try both and pick the first that works and not make it dependant on the release image (name). WDYT?

[carbonin]

I actually think that is how we use that function. The problem is that we end up running it all the time which isn't great but ... I suppose it depends on how confident we are in the release image naming.

[rccrdpccl]

@Prashanth684 would you have any recommendation on how to detect reliably OKD release image?

[Prashanth684]

unfortunately, there is no easy way to detect if release image is OKD outside of doing what oc does which is read the release image, parse the metadata and maybe check the componentversion to see if there is centos stream coreos string present there. The only way today is like you suggest to check for both and see which one works.

[Prashanth684]

this is checking the pullspec string right? so if a pullspec with digest is provided, this won't work?

[rccrdpccl]

Yes, what you say is correct - this should be changed.
Currently we check for the image tagged okd-rpms within the release image (oc adm release info --image-for=okd-rpms --insecure=false <release image>) - however this seems that it's not working any longer from release 4.16 onward. This would mean OKD assisted installs for OCP > 4.15 are not working properly. Could you please confirm that this method is no longer valid?

[Prashanth684]

right...we don't build the okd-rpms image anymore. The openshift binaries are pulled from ART's mirror (for now).

[Prashanth684]

you could check for stream-coreos instead as that is specific to OKD.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: carbonin, rccrdpccl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [carbonin,rccrdpccl]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[carbonin]

Looks like the OKD-specific job has been failing for quite a while now so it's unlikely that it's a problem with this PR

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 8f3da5d and 2 for PR HEAD 9a1128d in total

[openshift-ci]

@rccrdpccl: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/okd-scos-e2e-aws-ovn	9a1128d	link	false	/test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-bot]

[ART PR BUILD NOTIFIER]

Distgit: ose-agent-installer-api-server
This PR has been included in build ose-agent-installer-api-server-container-v4.20.0-202504290242.p0.g20e7243.assembly.stream.el9.
All builds following this will include this PR.