MGMT-20464: Fix NFD detection of NVIDIA GPUs

[jhernand]

When we introduced the support for the AMD GPU operator we changed the configuration of the NFD operator so that it detects the AMD GPUs and labels the nodes accordingly. But looks like that custom configuration disables completely the default behavior, and therefore it no longer detects NVIDIA GPUs. To avoid that this patch introduces an additional empty custom configuration, with should fix the issue.

List all the issues related to this PR

https://issues.redhat.com/browse/MGMT-20464

• New Feature
• Enhancement
• Bug fix
• Tests
• Documentation
• CI/CD

What environments does this code impact?

• Automation (CI, tools, etc)
• Cloud
• Operator Managed Deployments
• None

How was this code tested?

• assisted-test-infra environment
• dev-scripts environment
• Reviewer's test appreciated
• Waiting for CI to do a full test run
• Manual (Elaborate on how it was tested)
• No tests needed

Tested manually.

Checklist

• Title and description added to both, commit and PR.
• Relevant issues have been associated (see CONTRIBUTING guide)
• This change does not require a documentation update (docstring, docs, README, etc)
• Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

• Are the title and description (in both PR and commit) meaningful and clear?
• Is there a bug required (and linked) for this change?
• Should this PR be backported?

[openshift-ci-robot]

@jhernand: This pull request references MGMT-20464 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.19.0" version, but no target version was set.

In response to this:

When we introduced the support for the AMD GPU operator we changed the configuration of the NFD operator so that it detects the AMD GPUs and labels the nodes accordingly. But looks like that custom configuration disables completely the default behavior, and therefore it no longer detects NVIDIA GPUs. To avoid that this patch introduces an additional empty custom configuration, with should fix the issue.

List all the issues related to this PR

https://issues.redhat.com/browse/MGMT-20464

• New Feature
• Enhancement
• Bug fix
• Tests
• Documentation
• CI/CD

What environments does this code impact?

• Automation (CI, tools, etc)
• Cloud
• Operator Managed Deployments
• None

How was this code tested?

• assisted-test-infra environment
• dev-scripts environment
• Reviewer's test appreciated
• Waiting for CI to do a full test run
• Manual (Elaborate on how it was tested)
• No tests needed

Tested manually.

Checklist

• Title and description added to both, commit and PR.
• Relevant issues have been associated (see CONTRIBUTING guide)
• This change does not require a documentation update (docstring, docs, README, etc)
• Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

• Are the title and description (in both PR and commit) meaningful and clear?
• Is there a bug required (and linked) for this change?
• Should this PR be backported?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[jhernand]

FYI: @pastequo

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhernand

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jhernand]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.33%. Comparing base (31a16a4) to head (93945f6).

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #7597   +/-   ##
=======================================
  Coverage   67.33%   67.33%           
=======================================
  Files         335      335           
  Lines       42360    42360           
=======================================
+ Hits        28522    28525    +3     
+ Misses      11265    11263    -2     
+ Partials     2573     2572    -1     

see 2 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[openshift-ci]

@jhernand: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/okd-scos-e2e-aws-ovn	93945f6	link	false	/test okd-scos-e2e-aws-ovn
ci/prow/edge-e2e-metal-assisted-ai-amd-4-18	93945f6	link	true	/test edge-e2e-metal-assisted-ai-amd-4-18
ci/prow/edge-e2e-metal-assisted-ai-nvidia-4-18	93945f6	link	true	/test edge-e2e-metal-assisted-ai-nvidia-4-18
ci/prow/edge-images	93945f6	link	true	/test edge-images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.