-
Notifications
You must be signed in to change notification settings - Fork 236
OCPBUGS-55300: For agent-installer remove bypass of manifest generation #7606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-55300: For agent-installer remove bypass of manifest generation #7606
Conversation
@bfournie: This pull request references Jira Issue OCPBUGS-55300, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7606 +/- ##
==========================================
+ Coverage 67.34% 68.05% +0.71%
==========================================
Files 335 335
Lines 42363 44113 +1750
==========================================
+ Hits 28530 30022 +1492
- Misses 11261 11330 +69
- Partials 2572 2761 +189 🚀 New features to boost your workflow:
|
func skipAgentUpload(ctx context.Context, key string, s3Client s3wrapper.API) bool { | ||
skipFiles := []string{ | ||
"kubeadmin-password", | ||
"99_kubeadmin-password-secret.yaml", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From a quick test the console login is still broken. The password update is skipped, but it seems that "99_kubeadmin-password-secret.yaml"
is generated before (so this skip is ignored here essentially), so very likely it's stil being generated with the new kubeadmin-password.hash
When OVE UI uses the downloads/credentials endpoint the API handler generates the InstallConfig for the agent-based installer in order to make the credentials available in the Ready state. In order to prevent overwriting the kubeadmin-password, the generation of the InstallConfig the second time was bypassed (openshift#7546). This inadvertently prevented the operator manifests from also being generated, and since the OVE UI configures the operators after it retrieves the credentials, the operators are not correctly installed. This fix removes the bypass of the GenerateInstallConfig and skips the upload of the kubeadmin-password if it has already been uploaded in order to prevent overwriting it.
62fb342
to
60ead81
Compare
@bfournie: This pull request references Jira Issue OCPBUGS-55300, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@bfournie: This pull request references Jira Issue OCPBUGS-55300, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/retest-required |
/lgtm |
cc @danielerez for approval |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bfournie, danielerez The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
@bfournie: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
2039bff
into
openshift:master
@bfournie: Jira Issue OCPBUGS-55300: Some pull requests linked via external trackers have merged: The following pull requests linked via external trackers have not merged:
These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with Jira Issue OCPBUGS-55300 has not been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
[ART PR BUILD NOTIFIER] Distgit: ose-agent-installer-api-server |
When OVE UI uses the downloads/credentials endpoint the API handler generates the InstallConfig for the agent-based installer in order to make the credentials available in the Ready state. In order to prevent overwriting the kubeadmin-password, the generation of the InstallConfig the second time was bypassed (#7546). This inadvertently prevented the operator manifests from also being generated, and since the OVE UI configures the operators after it retrieves the credentials, the operators are not correctly installed.
This fix removes the bypass of the GenerateInstallConfig. To prevent the kubeadmin-password overwrite a installer change has been made openshift/installer#9679
List all the issues related to this PR
What environments does this code impact?
How was this code tested?
Checklist
docs
, README, etc)Reviewers Checklist