OCPBUGS-54319: mirror changes to openshift-installer with oci-eval-user-data

[prb112]

Mirror changes to oci-eval-user-data.sh in the installer

List all the issues related to this PR

• Bug fix

What environments does this code impact?

• Automation (CI, tools, etc)
• Cloud
• [] Operator Managed Deployments
• None

How was this code tested?

• Manual (Elaborate on how it was tested)
• No tests needed

The fix was run locally with an assisted setup.

Checklist

• Title and description added to both, commit and PR.
• Relevant issues have been associated (see CONTRIBUTING guide)
• This change does not require a documentation update (docstring, docs, README, etc)
• Does this change include unit-tests (note that code changes require unit-tests)
• NA on unit-tests due to being a shellscript

Reviewers Checklist

• Are the title and description (in both PR and commit) meaningful and clear? yes
• Is there a bug required (and linked) for this change? yes
• Should this PR be backported? yes to 4.18

[openshift-ci-robot]

@prb112: This pull request references Jira Issue OCPBUGS-54319, which is invalid:

• expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Mirror changes to oci-eval-user-data.sh in the installer

List all the issues related to this PR

• Bug fix

What environments does this code impact?

• Automation (CI, tools, etc)
• Cloud
• [] Operator Managed Deployments
• None

How was this code tested?

• Manual (Elaborate on how it was tested)
• No tests needed

The fix was run locally with an assisted setup.

Checklist

• Title and description added to both, commit and PR.
• Relevant issues have been associated (see CONTRIBUTING guide)
• This change does not require a documentation update (docstring, docs, README, etc)
• Does this change include unit-tests (note that code changes require unit-tests)
• NA on unit-tests due to being a shellscript

Reviewers Checklist

• Are the title and description (in both PR and commit) meaningful and clear? yes
• Is there a bug required (and linked) for this change? yes
• Should this PR be backported? yes to 4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[prb112]

/jira refresh

[openshift-ci-robot]

@prb112: This pull request references Jira Issue OCPBUGS-54319, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.19.0) matches configured target version for branch (4.19.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.76%. Comparing base (582b4f6) to head (3436404).
Report is 5 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #7619      +/-   ##
==========================================
+ Coverage   67.23%   68.76%   +1.52%     
==========================================
  Files         335      335              
  Lines       42528    45271    +2743     
==========================================
+ Hits        28594    31130    +2536     
- Misses      11348    11482     +134     
- Partials     2586     2659      +73     

see 12 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[prb112]

/retest-required

[prb112]

Hey @pawanpinjarkar can you review? Thank you, Paul

[prb112]

/test okd-scos-e2e-aws-ovn

[rccrdpccl]

okd-scos-e2e-aws-ovn seems broken, no need to retest it https://prow.ci.openshift.org/job-history/gs/test-platform-results/pr-logs/directory/pull-ci-openshift-assisted-service-master-okd-scos-e2e-aws-ovn
The PR will merge anyway as it's not required

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adriengentil, prb112

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [adriengentil]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[prb112]

Thank you @rccrdpccl

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 07e5c43 and 2 for PR HEAD 3436404 in total

[openshift-bot]

/jira refresh

The requirements for Jira bugs have changed (Jira issues linked to PRs on main branch need to target different OCP), recalculating validity.

[openshift-ci-robot]

@openshift-bot: This pull request references Jira Issue OCPBUGS-54319, which is invalid:

• expected the bug to target either version "4.20." or "openshift-4.20.", but it targets "4.19.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

The requirements for Jira bugs have changed (Jira issues linked to PRs on main branch need to target different OCP), recalculating validity.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[prb112]

/jira refresh

[openshift-ci-robot]

@prb112: This pull request references Jira Issue OCPBUGS-54319, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.20.0) matches configured target version for branch (4.20.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[rccrdpccl]

/test ?

[openshift-ci]

@rccrdpccl: The following commands are available to trigger required jobs:

/test e2e-agent-compact-ipv4

/test edge-assisted-operator-catalog-publish-verify

/test edge-ci-index

/test edge-e2e-ai-operator-disconnected-capi

/test edge-e2e-ai-operator-ztp

/test edge-e2e-ai-operator-ztp-3masters

/test edge-e2e-ai-operator-ztp-capi

/test edge-e2e-ai-operator-ztp-disconnected

/test edge-e2e-metal-assisted-4-14

/test edge-e2e-metal-assisted-4-15

/test edge-e2e-metal-assisted-4-16

/test edge-e2e-metal-assisted-4-17

/test edge-e2e-metal-assisted-4-19

/test edge-e2e-metal-assisted-5-control-planes-4-19

/test edge-e2e-metal-assisted-ai-amd-4-18

/test edge-e2e-metal-assisted-ai-nvidia-4-18

/test edge-e2e-metal-assisted-external-4-19

/test edge-e2e-metal-assisted-lvm-4-19

/test edge-e2e-metal-assisted-none-4-19

/test edge-e2e-metal-assisted-osc-4-19

/test edge-e2e-metal-assisted-virtualization-4-18

/test edge-e2e-nutanix-assisted-2workers-4-19

/test edge-e2e-nutanix-assisted-4-19

/test edge-e2e-vsphere-assisted-4-19

/test edge-images

/test edge-lint

/test edge-operator-publish-verify

/test edge-subsystem-aws

/test edge-subsystem-kubeapi-aws

/test edge-unit-test

/test edge-verify-generated-code

/test images

/test mce-images

/test verify-deps

The following commands are available to trigger optional jobs:

/test e2e-agent-4control-ipv4

/test e2e-agent-5control-ipv4

/test e2e-agent-ha-dualstack

/test e2e-agent-sno-ipv6

/test edge-e2e-ai-operator-ztp-4masters

/test edge-e2e-ai-operator-ztp-5masters

/test edge-e2e-ai-operator-ztp-compact-day2-masters

/test edge-e2e-ai-operator-ztp-compact-day2-workers

/test edge-e2e-ai-operator-ztp-multiarch-3masters-ocp

/test edge-e2e-ai-operator-ztp-multiarch-sno-ocp

/test edge-e2e-ai-operator-ztp-node-labels

/test edge-e2e-ai-operator-ztp-remove-node

/test edge-e2e-ai-operator-ztp-sno-day2-masters

/test edge-e2e-ai-operator-ztp-sno-day2-workers

/test edge-e2e-ai-operator-ztp-sno-day2-workers-ignitionoverride

/test edge-e2e-ai-operator-ztp-sno-day2-workers-late-binding

/test edge-e2e-metal-assisted-4-control-planes-4-19

/test edge-e2e-metal-assisted-4-masters-none-4-19

/test edge-e2e-metal-assisted-bond-4-14

/test edge-e2e-metal-assisted-bond-4-19

/test edge-e2e-metal-assisted-day2-4-19

/test edge-e2e-metal-assisted-day2-arm-workers-4-19

/test edge-e2e-metal-assisted-day2-sno-4-19

/test edge-e2e-metal-assisted-ipv4v6-4-19

/test edge-e2e-metal-assisted-ipv6-4-19

/test edge-e2e-metal-assisted-kube-api-late-binding-sno-4-19

/test edge-e2e-metal-assisted-kube-api-late-unbinding-sno-4-19

/test edge-e2e-metal-assisted-kube-api-net-suite-4-19

/test edge-e2e-metal-assisted-kube-api-umlb-4-19

/test edge-e2e-metal-assisted-onprem-4-19

/test edge-e2e-metal-assisted-osc-sno-4-19

/test edge-e2e-metal-assisted-sno-4-19

/test edge-e2e-metal-assisted-static-ip-suite-4-14

/test edge-e2e-metal-assisted-static-ip-suite-4-19

/test edge-e2e-metal-assisted-tang-4-19

/test edge-e2e-metal-assisted-tpmv2-4-19

/test edge-e2e-metal-assisted-umlb-4-19

/test edge-e2e-metal-assisted-upgrade-agent-4-19

/test edge-e2e-oci-assisted-4-19

/test edge-e2e-oci-assisted-bm-iscsi-4-19

/test edge-e2e-vsphere-assisted-umlb-4-19

/test edge-e2e-vsphere-assisted-umn-4-19

/test okd-scos-e2e-aws-ovn

/test okd-scos-images

/test push-pr-image

Use /test all to run the following jobs that were automatically triggered:

pull-ci-openshift-assisted-service-master-e2e-agent-compact-ipv4

pull-ci-openshift-assisted-service-master-edge-ci-index

pull-ci-openshift-assisted-service-master-edge-e2e-ai-operator-ztp

pull-ci-openshift-assisted-service-master-edge-e2e-metal-assisted-4-19

pull-ci-openshift-assisted-service-master-edge-images

pull-ci-openshift-assisted-service-master-edge-lint

pull-ci-openshift-assisted-service-master-edge-subsystem-aws

pull-ci-openshift-assisted-service-master-edge-subsystem-kubeapi-aws

pull-ci-openshift-assisted-service-master-edge-unit-test

pull-ci-openshift-assisted-service-master-edge-verify-generated-code

pull-ci-openshift-assisted-service-master-images

pull-ci-openshift-assisted-service-master-mce-images

pull-ci-openshift-assisted-service-master-okd-scos-e2e-aws-ovn

pull-ci-openshift-assisted-service-master-verify-deps

Details

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[rccrdpccl]

/test verify-deps

[rccrdpccl]

/ok-to-test

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 36feaa4 and 2 for PR HEAD 3436404 in total

[openshift-ci]

@prb112: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[gamli75]

/retest

[openshift-ci-robot]

@prb112: Jira Issue OCPBUGS-54319: All pull requests linked via external trackers have merged:

• openshift/installer#9608
• openshift/assisted-service#7619

Jira Issue OCPBUGS-54319 has been moved to the MODIFIED state.

Details

In response to this:

Mirror changes to oci-eval-user-data.sh in the installer

List all the issues related to this PR

• Bug fix

What environments does this code impact?

• Automation (CI, tools, etc)
• Cloud
• [] Operator Managed Deployments
• None

How was this code tested?

• Manual (Elaborate on how it was tested)
• No tests needed

The fix was run locally with an assisted setup.

Checklist

• Title and description added to both, commit and PR.
• Relevant issues have been associated (see CONTRIBUTING guide)
• This change does not require a documentation update (docstring, docs, README, etc)
• Does this change include unit-tests (note that code changes require unit-tests)
• NA on unit-tests due to being a shellscript

Reviewers Checklist

• Are the title and description (in both PR and commit) meaningful and clear? yes
• Is there a bug required (and linked) for this change? yes
• Should this PR be backported? yes to 4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-bot]

[ART PR BUILD NOTIFIER]

Distgit: ose-agent-installer-api-server
This PR has been included in build ose-agent-installer-api-server-container-v4.20.0-202505052112.p0.gcb267b3.assembly.stream.el9.
All builds following this will include this PR.

[prb112]

/cherry-pick release-4.19

[openshift-cherrypick-robot]

@prb112: new pull request created: #7670

Details

In response to this:

/cherry-pick release-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.