MGMT-20527: Ensure no_proxy contains no duplicates in the install command #7621
Conversation
The agent validates no_proxy using the `ValidateNoProxyFormat` function which was recently changed to ensure no duplicates exist. If a user adds one of the entries that the install command is trying to add automatically, this caused duplicates and the install command failed verification. Resolves https://issues.redhat.com/browse/MGMT-20527
carbonin
changed the title
openshift-ci-robot
added
the
jira/valid-reference
|
@carbonin: This pull request references MGMT-20527 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
added
the
size/XS
openshift-ci
bot
added
the
approved
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: carbonin, trewest The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7621 +/- ##
=======================================
Coverage 67.26% 67.26%
=======================================
Files 335 335
Lines 42621 42621
=======================================
Hits 28669 28669
Misses 11360 11360
Partials 2592 2592
🚀 New features to boost your workflow:
|
|
/retest |
|
/cherry-pick release-ocm-2.13 |
|
@carbonin: once the present PR merges, I will cherry-pick it on top of In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/override ci/prow/okd-scos-e2e-aws-ovn |
|
@gamli75: Overrode contexts on behalf of gamli75: ci/prow/okd-scos-e2e-aws-ovn In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/retest |
|
@carbonin: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
The agent validates no_proxy using the
ValidateNoProxyFormatfunction which was recently changed to ensure no duplicates exist.If a user adds one of the entries that the install command is trying to add automatically, this caused duplicates and the install command failed verification.
List all the issues related to this PR
Resolves https://issues.redhat.com/browse/MGMT-20527
What environments does this code impact?
How was this code tested?
Unit tests and @trewest is testing manually in the environment where the bug was found.
Checklist
docs, README, etc)Reviewers Checklist