Skip to content

Conversation

@openshift-cherrypick-robot

This is an automated cherry-pick of #8244

/assign CrystalChun

There is one case where a PreprovisioningImage should not be
deleted before its associated BMH. This happens when the BMH
has automatedCleaningMode set to metadata (enabled) and is being
deleted. The PreprovisioningImage is required during deprovisioning
since it contains the Ironic Python Agent (IPA) which is used
to erase the disk of the host.

In this specific case, we should not allow a PreprovisioningImage
to be removed before the BMH is removed. The finalizer is
added to all PreprovisioningImage CRs we manage, and will
be removed on deletion of the PreprovisioningImage unless
the case above is occuring.
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 4, 2025

@openshift-cherrypick-robot: Ignoring requests to cherry-pick non-bug issues: ACM-26034

In response to this:

This is an automated cherry-pick of #8244

/assign CrystalChun

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 4, 2025
@coderabbitai
Copy link

coderabbitai bot commented Nov 4, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci bot requested review from pastequo and romfreiman November 4, 2025 23:32
@openshift-ci
Copy link

openshift-ci bot commented Nov 4, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: openshift-cherrypick-robot
Once this PR has been reviewed and has the lgtm label, please assign danmanor for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@CrystalChun
Copy link
Contributor

CrystalChun commented Nov 4, 2025

/retitle [release-ocm-2.13] ACM-26035: Introduce PreprovisioningImage finalizer

@openshift-ci openshift-ci bot changed the title [release-ocm-2.13] ACM-26034: Introduce PreprovisioningImage finalizer [release-ocm-2.13] ACM-26035: Introduce PreprovisioningImage finalizer Nov 4, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 4, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 4, 2025

@openshift-cherrypick-robot: This pull request references ACM-26035 which is a valid jira issue.

In response to this:

This is an automated cherry-pick of #8244

/assign CrystalChun

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@CrystalChun
Copy link
Contributor

/cc @gamli75

@openshift-ci openshift-ci bot requested a review from gamli75 November 4, 2025 23:53
@codecov
Copy link

codecov bot commented Nov 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 38.27%. Comparing base (0ee7bc5) to head (8c13c89).

Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                  @@
##           release-ocm-2.13    #8246      +/-   ##
====================================================
- Coverage             42.72%   38.27%   -4.46%     
====================================================
  Files                   346      315      -31     
  Lines                 65812    55347   -10465     
====================================================
- Hits                  28121    21186    -6935     
+ Misses                35168    32276    -2892     
+ Partials               2523     1885     -638     

see 33 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gamli75
Copy link
Contributor

gamli75 commented Nov 5, 2025

/retest-required

@openshift-ci
Copy link

openshift-ci bot commented Nov 5, 2025

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/mce-images 8c13c89 link true /test mce-images
ci/prow/images 8c13c89 link true /test images
ci/prow/e2e-ai-operator-ztp 8c13c89 link true /test e2e-ai-operator-ztp
ci/prow/lint 8c13c89 link true /test lint
ci/prow/subsystem-aws 8c13c89 link true /test subsystem-aws
ci/prow/verify-generated-code 8c13c89 link true /test verify-generated-code
ci/prow/e2e-ai-operator-disconnected-capi 8c13c89 link true /test e2e-ai-operator-disconnected-capi
ci/prow/e2e-ai-operator-ztp-capi 8c13c89 link true /test e2e-ai-operator-ztp-capi
ci/prow/ci-index 8c13c89 link true /test ci-index
ci/prow/subsystem-kubeapi-aws 8c13c89 link true /test subsystem-kubeapi-aws
ci/prow/unit-test 8c13c89 link true /test unit-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants