-
Notifications
You must be signed in to change notification settings - Fork 244
[release-ocm-2.13] ACM-26035: Introduce PreprovisioningImage finalizer #8246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release-ocm-2.13
Are you sure you want to change the base?
Conversation
There is one case where a PreprovisioningImage should not be deleted before its associated BMH. This happens when the BMH has automatedCleaningMode set to metadata (enabled) and is being deleted. The PreprovisioningImage is required during deprovisioning since it contains the Ironic Python Agent (IPA) which is used to erase the disk of the host. In this specific case, we should not allow a PreprovisioningImage to be removed before the BMH is removed. The finalizer is added to all PreprovisioningImage CRs we manage, and will be removed on deletion of the PreprovisioningImage unless the case above is occuring.
|
@openshift-cherrypick-robot: Ignoring requests to cherry-pick non-bug issues: ACM-26034 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: openshift-cherrypick-robot The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retitle [release-ocm-2.13] ACM-26035: Introduce PreprovisioningImage finalizer |
|
@openshift-cherrypick-robot: This pull request references ACM-26035 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/cc @gamli75 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release-ocm-2.13 #8246 +/- ##
====================================================
- Coverage 42.72% 38.27% -4.46%
====================================================
Files 346 315 -31
Lines 65812 55347 -10465
====================================================
- Hits 28121 21186 -6935
+ Misses 35168 32276 -2892
+ Partials 2523 1885 -638 🚀 New features to boost your workflow:
|
|
/retest-required |
|
@openshift-cherrypick-robot: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This is an automated cherry-pick of #8244
/assign CrystalChun