[release-4.21] MGMT-22561: Fix YAML marshaling for Kubernetes types in disconnected ignition #8702
Conversation
Replace gopkg.in/yaml.v2 with sigs.k8s.io/yaml for marshaling Kubernetes
manifests. The yaml.v2 library uses struct field names when no yaml: tag
is present, but K8s types use json: tags. This caused openshift-install
to fail with "unknown field objectmeta" when parsing generated manifests.
Also adds disconnected-iso to the discovery_iso_type query parameter enum
to allow requesting disconnected ignition via the download endpoint, and
fixes a typo in the parameter description ("disovery" -> "discovery").
|
@openshift-cherrypick-robot: Ignoring requests to cherry-pick non-bug issues: MGMT-22545 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Important Review skippedAuto reviews are limited based on label configuration. 🚫 Review skipped — only excluded labels are configured. (1)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Comment |
openshift-ci
bot
added
the
size/XS
openshift-ci
bot
added
the
api-review
|
/lgtm |
|
/override ci/prow/okd-scos-images |
|
@omer-vishlitzky: omer-vishlitzky unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file, and the following github teams:openshift: openshift-release-oversight openshift-staff-engineers openshift-sustaining-engineers. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/override ci/prow/okd-scos-images |
|
@danielerez: Overrode contexts on behalf of danielerez: ci/prow/okd-scos-images DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@openshift-cherrypick-robot: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danielerez, openshift-cherrypick-robot The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/retitle [release-4.21] MGMT-22561: Fix YAML marshaling for Kubernetes types in disconnected ignition |
openshift-ci
bot
changed the title
|
@openshift-cherrypick-robot: This pull request references MGMT-22561 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.21.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/valid-reference
|
/jira refresh |
|
@omer-vishlitzky: This pull request references MGMT-22561 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
4 participants
This is an automated cherry-pick of #8619
/assign omer-vishlitzky