add support for virt bundle operators

[eliajahshan]

Adding support for virt bundle in test infra
will set up operators required for virt bundle

@bkopilov @danmanor @dudyas6

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: eliajahshan
Once this PR has been reviewed and has the lgtm label, please assign rccrdpccl for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

Hi @eliajahshan. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[eliajahshan]

/test lint

[openshift-ci]

@eliajahshan: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test lint

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[bkopilov]

@eliajahshan , yes we can use it and it will be managed here when something change... i think you can use const.OperatorType as naming.

@danmanor Is it ok ? we are going to switch to bundles

[danmanor]

Yes, have to tested it @eliajahshan ?

[openshift-ci]

@eliajahshan: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest-required

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[danmanor]

/ok-to-test

[danmanor]

@eliajahshan @bkopilov I think it would be better if we will expand this solution to be more generic, then we could use it in our CI as well. For example I think we should add 3 new constants:

virt_bundle_operators = ["cnv", ...]
ai_amd_bundle = [...]
ao_nvidia_bundle = [..]

and add a new installation parameter CLUSTER_BUNDLE that could be set to either ai-amd, ai-nvidia or virtualization, then we will be able to just parameterize a stadard test: @pytest.mark.parametrize("cluster_bundle", [virtualization]).

WDYT ?

[bkopilov]

@eliajahshan @bkopilov I think it would be better if we will expand this solution to be more generic, then we could use it in our CI as well. For example I think we should add 3 new constants:

virt_bundle_operators = ["cnv", ...]
ai_amd_bundle = [...]
ao_nvidia_bundle = [..]

and add a new installation parameter CLUSTER_BUNDLE that could be set to either ai-amd, ai-nvidia or virtualization, then we will be able to just parameterize a stadard test: @pytest.mark.parametrize("cluster_bundle", [virtualization]).

WDYT ?

Sounds good to me

[eliajahshan]

@danmanor I like the idea , i can do this starting with the virt bundle

[openshift-ci]

@eliajahshan: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-metal-assisted-ha-kube-api-4-19	f50bd3f	link	true	/test e2e-metal-assisted-ha-kube-api-4-19
ci/prow/ansible-lint	f50bd3f	link	true	/test ansible-lint

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.