NO-JIRA: e2e: fix label-filter shell quoting in test-e2e target

[tashirj]

Problem

make test-e2e fails immediately with a Ginkgo label-filter syntax error because bash word-splits the unquoted $(E2E_GINKGO_LABEL_FILTER) expansion at spaces and &&.

Fix

Wrap $(E2E_GINKGO_LABEL_FILTER) in single quotes at the Makefile call site.

Same fix as #447 (merged to cert-manager-1.19).

Note

A companion PR to openshift/release is required to remove embedded " from CI E2E_GINKGO_LABEL_FILTER job values once this lands.

Test plan

• make test-e2e with default filter parses correctly
• CI e2e jobs pass after openshift/release update

Summary by CodeRabbit

• Tests
  • Updated end-to-end test execution to handle label filters more reliably during test runs.

[coderabbitai]

Walkthrough

The test-e2e Makefile target's go test invocation now wraps the E2E_GINKGO_LABEL_FILTER variable in single quotes when passed to the -ginkgo.label-filter flag, rather than leaving it unquoted.

Changes

Makefile e2e label filter quoting

Layer / File(s)	Summary
Quote label filter argument Makefile	The -ginkgo.label-filter flag now uses '$(E2E_GINKGO_LABEL_FILTER)' instead of the unquoted variable form.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	Only Makefile changed; no Ginkgo It/Describe/Context titles were added or modified.
Test Structure And Quality	✅ Passed	Only Makefile changed; no Ginkgo test files or test logic were modified, so the test-quality checklist is not applicable.
Microshift Test Compatibility	✅ Passed	Only Makefile quoting changed; no Ginkgo tests, APIs, namespaces, or MicroShift-sensitive e2e logic were added or modified.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	Only Makefile changed; no new or modified Ginkgo e2e tests were added, so the SNO compatibility check is not applicable.
Topology-Aware Scheduling Compatibility	✅ Passed	Only a Makefile quoting fix in test-e2e changed; no manifests, controllers, or scheduling logic were modified.
Ote Binary Stdout Contract	✅ Passed	Only Makefile quoting changed; no process-level code or stdout writes were modified.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	Only a Makefile label-filter quoting change was made; no new Ginkgo tests or network-dependent code were added.
No-Weak-Crypto	✅ Passed	Only change is shell quoting in Makefile; no crypto, weak cipher, or secret-comparison code was added.
Container-Privileges	✅ Passed	PASS: The PR only changes Makefile quoting for test-e2e; HEAD^..HEAD shows no container/K8s manifest edits or added privileged/hostPID/hostNetwork settings.
No-Sensitive-Data-In-Logs	✅ Passed	Only a Makefile quoting fix changed; no logging or sensitive-data exposure was added.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the main change: quoting the E2E label filter in the test-e2e target.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-ci]

Hi @tashirj. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[arun717]

/lgtm

[arun717]

override failing jobs, which is because of label parsing issue, addressed in openshift/release#81499

/override ci/prow/e2e-operator

[openshift-ci]

@arun717: arun717 unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file, and the following github teams:openshift: openshift-release-oversight openshift-staff-engineers openshift-sustaining-engineers.

Details

In response to this:

override failing jobs, which is because of label parsing issue, addressed in openshift/release#81499

/override ci/prow/e2e-operator

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[bharath-b-rh]

The e2e CI jobs are failing because of the missing dependent change in openshift/release repo. Overriding here and will rehearsed in release repo with required changes.

/lgtm
/approve
/label docs-approved
/label qe-approved
/label px-approved

/override ci/prow/e2e-operator
/override ci/prow/e2e-operator-tech-preview

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: arun717, bharath-b-rh, tashirj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [bharath-b-rh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@bharath-b-rh: Overrode contexts on behalf of bharath-b-rh: ci/prow/e2e-operator, ci/prow/e2e-operator-tech-preview

Details

In response to this:

The e2e CI jobs are failing because of the missing dependent change in openshift/release repo. Overriding here and will rehearsed in release repo with required changes.

/lgtm
/approve
/label docs-approved
/label qe-approved
/label px-approved

/override ci/prow/e2e-operator
/override ci/prow/e2e-operator-tech-preview

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-ci]

@tashirj: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-operator-tech-preview	0e23ea7	link	false	/test e2e-operator-tech-preview
ci/prow/e2e-operator	0e23ea7	link	true	/test e2e-operator

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[bharath-b-rh]

/ok-to-test

[bharath-b-rh]

/retitle NO-JIRA: e2e: fix label-filter shell quoting in test-e2e target

[openshift-ci-robot]

@tashirj: This pull request explicitly references no jira issue.

Details

In response to this:

Problem

make test-e2e fails immediately with a Ginkgo label-filter syntax error because bash word-splits the unquoted $(E2E_GINKGO_LABEL_FILTER) expansion at spaces and &&.

Fix

Wrap $(E2E_GINKGO_LABEL_FILTER) in single quotes at the Makefile call site.

Same fix as #447 (merged to cert-manager-1.19).

Note

A companion PR to openshift/release is required to remove embedded " from CI E2E_GINKGO_LABEL_FILTER job values once this lands.

Test plan

• make test-e2e with default filter parses correctly
• CI e2e jobs pass after openshift/release update

Summary by CodeRabbit

• Tests
• Updated end-to-end test execution to handle label filters more reliably during test runs.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.