[DPTP-4313] Respecting always_run from config file

[hector-vido]

The field always_run is auto-generated based in the following condition:

AlwaysRun: opts.runIfChanged == "" && opts.skipIfOnlyChanged == "" && !opts.defaultDisable && opts.pipelineRunIfChanged == "",

But it is only updated if and only if there is no reference to an older configuration, if there is a valid reference, the old value is used and the new one is ignored:

if oldJob, existed := oldJobs[newJobName]; existed {
    mergedJobs = append(mergedJobs, mergePresubmits(&oldJob, &newJob))
} else {
    mergedJobs = append(mergedJobs, newJob)
}

I simply removed the property overriding of AlwaysRun, allowing it to use the logic that already exists and is battle tested.

In addition, some other small changes have been made to improve readability.

This modification can affect a lot of jobs.

[hector-vido]

/test unit

[jmguzik]

/hold

Evaluation is needed if the function that assigns old values makes sense

[hector-vido]

/unhold

[hector-vido]

/test e2e

[hector-vido]

/test images

[hector-vido]

/test e2e

[hector-vido]

/test e2e

[hector-vido]

/test e2e

[hector-vido]

/test e2e

[hector-vido]

/hold

[hector-vido]

/unhold

[hector-vido]

/hold

[hector-vido]

/override ci/prow/breaking-changes

[openshift-ci]

@hector-vido: Overrode contexts on behalf of hector-vido: ci/prow/breaking-changes

In response to this:

/override ci/prow/breaking-changes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-ci-robot]

/test remaining-required

[hector-vido]

/unhold

[jmguzik]

/hold

[openshift-ci]

New changes are detected. LGTM label has been removed.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hector-vido, jmguzik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [hector-vido,jmguzik]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@hector-vido: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/integration	2dceb5f	link	true	/test integration
ci/prow/security	2dceb5f	link	false	/test security
ci/prow/images	2dceb5f	link	true	/test images
ci/prow/breaking-changes	2dceb5f	link	false	/test breaking-changes

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.