-
Notifications
You must be signed in to change notification settings - Fork 279
[DPTP-4313] Respecting always_run from config file #4529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
b93df6f
to
6cacf19
Compare
3a774ad
to
ad4d383
Compare
/test unit |
/hold Evaluation is needed if the function that assigns old values makes sense |
ad4d383
to
0148be1
Compare
/unhold |
0148be1
to
72b96a0
Compare
b908cfc
to
fd4cabd
Compare
/test e2e |
/test images |
/test e2e |
2 similar comments
/test e2e |
/test e2e |
/test e2e |
fd4cabd
to
4170932
Compare
/hold |
/unhold |
/hold |
/override ci/prow/breaking-changes |
@hector-vido: Overrode contexts on behalf of hector-vido: ci/prow/breaking-changes In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/test remaining-required |
/unhold |
/hold |
4170932
to
32fb120
Compare
New changes are detected. LGTM label has been removed. |
32fb120
to
1fc2413
Compare
1fc2413
to
489af82
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hector-vido, jmguzik The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
489af82
to
cc08a49
Compare
cc08a49
to
2dceb5f
Compare
@hector-vido: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
The field
always_run
is auto-generated based in the following condition:But it is only updated if and only if there is no reference to an older configuration, if there is a valid reference, the old value is used and the new one is ignored:
I simply removed the property overriding of
AlwaysRun
, allowing it to use the logic that already exists and is battle tested.In addition, some other small changes have been made to improve readability.
This modification can affect a lot of jobs.