Skip to content

DPTP-4341: Support for referencePolicy Source while importing release payload #4576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 2, 2025
Merged

DPTP-4341: Support for referencePolicy Source while importing release payload #4576

merged 1 commit into from
Jun 2, 2025
+170 −27

Conversation

deepsm007
Copy link
Contributor

@deepsm007 deepsm007 commented May 7, 2025 •
edited
Loading

Addition of a new "reference_policy" field to ci-operator configuration releases stanza:

releases:
  initial:
    integration:
      name: "4.19"
      namespace: ocp
      reference_policy: Source
  latest:
    integration:
      include_built_images: true
      name: "4.19"
      namespace: ocp
      reference_policy: Source

When specified, reference_policy: source would change the imagestream referencePolicy.type to "Source". In addition, when this mode is encountered, "oc adm release new" should invoked with "reference-mode=source" as an argument.

/cc @openshift/test-platform

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 7, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 7, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 7, 2025
@deepsm007
Copy link
Contributor Author

/test all

@deepsm007
Copy link
Contributor Author

/retest-required

@deepsm007 deepsm007 changed the title Support for referencePolicy Source while importing release payload DPTP-4341: Support for referencePolicy Source while importing release payload May 13, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 13, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 13, 2025 •
edited by openshift-ci bot
Loading

@deepsm007: This pull request references DPTP-4341 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@deepsm007 deepsm007 force-pushed the DPTP-4341 branch 4 times, most recently from aa56b5a to 3dd09b8 Compare May 14, 2025 16:08
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 14, 2025 •
edited by openshift-ci bot
Loading

@deepsm007: This pull request references DPTP-4341 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

Addition of a new "reference_policy" field to ci-operator configuration releases stanza:

releases:
 initial:
   integration:
     name: "4.19"
     namespace: ocp
     reference_policy: source
 latest:
   integration:
     include_built_images: true
     name: "4.19"
     namespace: ocp
     reference_policy: source

When specified, reference_policy: source would change the imagestream referencePolicy.type to "Source"

/cc @openshift/test-platform

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@deepsm007 deepsm007 force-pushed the DPTP-4341 branch 2 times, most recently from e004077 to 819d019 Compare May 14, 2025 16:13
@deepsm007
Copy link
Contributor Author

/hold

@deepsm007 deepsm007 marked this pull request as ready for review May 14, 2025 16:20
@openshift-ci openshift-ci bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels May 14, 2025
@deepsm007 deepsm007 force-pushed the DPTP-4341 branch 5 times, most recently from 9250eb0 to 9a4598e Compare May 14, 2025 18:42
@deepsm007
Copy link
Contributor Author

/test e2e

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 14, 2025 •
edited by openshift-ci bot
Loading

@deepsm007: This pull request references DPTP-4341 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

Addition of a new "reference_policy" field to ci-operator configuration releases stanza:

releases:
 initial:
   integration:
     name: "4.19"
     namespace: ocp
     reference_policy: Source
 latest:
   integration:
     include_built_images: true
     name: "4.19"
     namespace: ocp
     reference_policy: Source

When specified, reference_policy: source would change the imagestream referencePolicy.type to "Source"

/cc @openshift/test-platform

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jupierce
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 14, 2025
@deepsm007
Copy link
Contributor Author

/test e2e

@deepsm007 deepsm007 force-pushed the DPTP-4341 branch 2 times, most recently from 4869afa to ac5cfc8 Compare May 30, 2025 17:04
@deepsm007
Copy link
Contributor Author

/test e2e

@deepsm007
Copy link
Contributor Author

/test e2e

@deepsm007 deepsm007 force-pushed the DPTP-4341 branch 3 times, most recently from 9b89efa to 3b1beed Compare May 30, 2025 21:23
@deepsm007
Copy link
Contributor Author

/test e2e

@deepsm007
Copy link
Contributor Author

/retest

@pruan-rht
Copy link
Member

/override ci/prow/security

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 30, 2025

@pruan-rht: Overrode contexts on behalf of pruan-rht: ci/prow/security

In response to this:

/override ci/prow/security

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@deepsm007
Copy link
Contributor Author

/test e2e

UPDATE=true go test ./... no changes after executing

@deepsm007
Support for referencePolicy Source while importing release payload & …
ee1e040 
…Update reference-mode=source for creating new payloads
@Prucek
Copy link
Member

Prucek commented Jun 2, 2025

/test e2e

@deepsm007
Copy link
Contributor Author

/retest

@deepsm007
Copy link
Contributor Author

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 2, 2025
@deepsm007
Copy link
Contributor Author

/override ci/prow/security

@hector-vido
Copy link
Contributor

/lgtm

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jun 2, 2025

@deepsm007: Overrode contexts on behalf of deepsm007: ci/prow/security

In response to this:

/override ci/prow/security

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 2, 2025
@openshift-ci-robot
Copy link
Contributor

/test remaining-required

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jun 2, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deepsm007, hector-vido, jupierce, pruan-rht

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [deepsm007,hector-vido,pruan-rht]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jun 2, 2025

@deepsm007: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit f1e07f9 into openshift:main Jun 2, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danilo-gemoli danilo-gemoli danilo-gemoli requested changes

Assignees

@pruan-rht pruan-rht

@jupierce jupierce

@danilo-gemoli danilo-gemoli

@hector-vido hector-vido

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@deepsm007 @openshift-ci-robot @jupierce @pruan-rht @danilo-gemoli @Prucek @hector-vido