OCPCLOUD-3094: Merge https://github.com/kubernetes/cloud-provider-gcp:master (2e53900) into main#93
Merged
openshift-merge-bot[bot] merged 35 commits intoopenshift:mainfrom Nov 10, 2025
Conversation
This is checked in newer versions of go
The `GetLoadBalancer` function returns `found=true` with an empty status if the underlying forwarding rule is deleted but the Service object still contains a finalizer (`ILBFinalizerV1` or `NetLBFinalizerV1`). This indicates to the controller that resource cleanup is still in progress. This commit updates `TestGetLoadBalancer` to verify this behavior. After the load balancer is deleted, the test now adds a finalizer to the service and asserts that `GetLoadBalancer` correctly returns `found=true`.
Update k8s dependencies to 1.33.4.
The `GetLoadBalancer` function returns `found=true` with an empty status if the underlying forwarding rule is deleted but the Service object still contains a finalizer (`ILBFinalizerV1` or `NetLBFinalizerV1`). This indicates to the controller that resource cleanup is still in progress. This commit updates `TestGetLoadBalancer` to verify this behavior. After the load balancer is deleted, the test now adds a finalizer to the service and asserts that `GetLoadBalancer` correctly returns `found=true`.
…balancer Update TestGetLoadBalancer with finalizer check
example - go test -count=1 -race -v $(go list ./...)
Adding SyncMutex as unit tests is failing when detecting race
TestGetLoadBalancer improvement: finalizer check logic in GetLoadBalancer
…rovider_tests tests: fix linting problem
…1-33-4 go.mod: Update k8s replace dependencies to 1.33.4
…lag to the CCM binary. (kubernetes#843) When enabled, NetLB controller will consider RBS the default implementation for L4 NetLBs without a LoadBalancerClass specified, and it will not provision the service.
This commit updates all k8s.io dependencies to version v0.34.0. This also updates the vendor directory and regenerates the Bazel BUILD files.
This commit updates the cluster provisioning scripts located in the /cluster directory to match the state of the upstream kubernetes/kubernetes repository at version v1.34.0.
Update Kubernetes dependencies to v0.34.0
… modify mn test with the flag
Add enableMultiNetworking flag and clarify the multi-networking judgement logic
Copy source code files from k8s.io/cloud-provider/tree/master/controllers/service Repo: https://github.com/kubernetes/cloud-provider/tree/master/controllers/service Paths: //pkg/controller/service Commit Hash: e890f14
Copy Service controller from kubernetes/cloud-provider/controllers/service/ Add logic to handle services which specify CCM loadBalancerClass `networking.gke.io/l4-regional-external-legacy` and `networking.gke.io/l4-regional-internal-legacy`. Existing controller will still handle services without a LoadBalancerClass, gkeService (forked) will only process services which specify one of the above LoadBalancerClass.
Followup: improve comment clarity for multi-NIC use cases
…ntroller Move over Service controller - handle CCM LoadBalancerClass
This change addresses an issue where the `lastTransitionTime` field in the `LoadBalancerPortsError` condition was null. This would happen when a service was created with mixed protocols (e.g., TCP and UDP), which is not supported by the L4 regional external and internal load balancers. According to the Kubernetes API specification, `lastTransitionTime` is a required field.
…condition-fix Populate lastTransitionTime for LoadBalancerPortsError
This adds the .spec required for building auth-provider-gcp as an RPM To keep naming consistent across credential provider specs, we use the name gcr-credential-provider It also includes build-rpms.sh, used to build the RPM in CI.
…r image to be consistent with ART for 4.21 Reconciling with https://github.com/openshift/ocp-build-data/tree/3fdad9b43ac7aa4e2ed5db0c6f5266809a9ebbc0/images/ose-gcp-cloud-controller-manager.yml
theobarberbany
force-pushed
the
tb/rebase-1.34
branch
from
a2e5f42 to
f64c175
Compare
Author
|
/verify-owners |
openshift-ci
bot
removed
the
do-not-merge/invalid-owners-file
|
/retest |
Author
|
sigh CI is flakey / broken at the moment. We had all tests green pre OWNERS update /retest |
Author
|
/hold we want to see if we can get kubernetes#911 merged |
openshift-ci
bot
added
the
do-not-merge/hold
Member
|
@theobarberbany I'd say let's merge this anyway and get kubernetes#911 as soon as we get it in a follow up |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nrb The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Member
|
/retest |
Member
|
/label rebase/manual To avoid this getting force pushed by the rebasebot, given we've already approved it |
openshift-ci
bot
added
the
rebase/manual
|
@theobarberbany: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/verified by @sunzhaohua2 |
openshift-ci-robot
added
the
verified
|
@sunzhaohua2: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/unhold |
openshift-ci
bot
removed
the
do-not-merge/hold
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
16 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Manual rebase to fix conflicts with e4f8177