CNTRLPLANE-805: Add TNF pacemaker fencing setup #1421
Conversation
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
openshift-ci
bot
added
the
approved
slintes
changed the title
openshift-ci-robot
added
the
jira/valid-reference
|
@slintes: This pull request references CNTRLPLANE-805 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@slintes: This pull request references CNTRLPLANE-805 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@slintes: This pull request references CNTRLPLANE-805 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@slintes: This pull request references CNTRLPLANE-805 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
slintes
changed the title
Signed-off-by: Marc Sluiter <[email protected]>
Signed-off-by: Marc Sluiter <[email protected]>
Signed-off-by: Marc Sluiter <[email protected]>
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
@slintes: This pull request references CNTRLPLANE-805 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
clobrano
left a comment
clobrano
left a comment
There was a problem hiding this comment.
What a PR! :)
I added a couple of minor notes, and I will have a look again tomorrow, but it looks good to me
|
|
||
| const replaceWith = "<REDACTED>" | ||
|
|
||
| var ( |
pkg/tnf/operator/starter.go
Outdated
| func handleFencingSecretChange(ctx context.Context, client kubernetes.Interface, oldObj, obj interface{}) { | ||
| secret, ok := obj.(*corev1.Secret) | ||
| if !ok { | ||
| klog.Warningf("failed to convert added / modifed / deleted object to Secret %+v", obj) |
pkg/tnf/operator/starter.go
Outdated
| klog.Infof("fencing job not found, skipping recreation") | ||
| return true, nil |
There was a problem hiding this comment.
It took me a little to understand this because the function name isFencingJobRunning and the returned boolean done are kind of the opposite :D.
isFencingJobRunning returns true when is not running.
Not fundamental, but might we consider changing the name?
There was a problem hiding this comment.
good catch, no clue why I named it this way 🤔 🤣
- fixed typo - renamed and clarified job wait function Signed-off-by: Marc Sluiter <[email protected]>
openshift-ci
bot
added
the
do-not-merge/hold
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: clobrano, slintes The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
let's not wait longer for #1431 @dusk125 @sandeepknd @tjungblu |
openshift-ci
bot
removed
the
do-not-merge/hold
1 similar comment
|
/override ci/prow/e2e-aws-cpms |
|
@dusk125: Overrode contexts on behalf of dusk125: ci/prow/e2e-aws-cpms, ci/prow/e2e-aws-ovn-etcd-scaling DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@dusk125 can you override ci/prow/e2e-aws-cpms again please, somehow that didn't last long 🤷🏼♂️ |
|
/override ci/prow/e2e-aws-cpms |
|
@dusk125: Overrode contexts on behalf of dusk125: ci/prow/e2e-aws-cpms DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
and now ci/prow/e2e-aws-ovn-etcd-scaling is running again... :/ |
|
/override ci/prow/e2e-azure-ovn-etcd-scaling |
|
@dusk125: Overrode contexts on behalf of dusk125: ci/prow/e2e-azure-ovn-etcd-scaling DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test ci/prow/unit |
|
@slintes: The specified target(s) for The following commands are available to trigger optional jobs: Use DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test unit |
1 similar comment
|
@slintes: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/override ci/prow/e2e-aws-ovn-etcd-scaling |
|
@dusk125: Overrode contexts on behalf of dusk125: ci/prow/e2e-aws-ovn-etcd-scaling DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
openshift-merge-bot
bot
merged commit e1880b7
into
openshift:main
|
[ART PR BUILD NOTIFIER] Distgit: cluster-etcd-operator |
5 participants
This PR adds pacemaker fencing setup:
statuscommandBlocked by:
openshift/installer#9635and for testing:
metal3-io/metal3-dev-env#1528openshift-metal3/dev-scripts#1751openshift-metal3/dev-scripts#1757TODO