OCPBUGS-81500: fix: udpate healthcheck previous state only after successful operator status update

[fracappa]

Previously, getPacemakerStatus updated c.previous before updateOperatorStatus was called. If the status update failed, subsequent syncs would skip processing because c.previous already reflected the new CR timestamp, leaving PacemakerHealthCheckDegraded stuck a True indefinitely.

Summary by CodeRabbit

Bug Fixes

• Corrected Pacemaker health check status tracking to ensure accurate grace-period timing and state transitions
• Fixed handling of unknown status values during operator condition updates
• Improved reliability of health check status persistence logic

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[openshift-ci-robot]

@fracappa: This pull request references Jira Issue OCPBUGS-81500, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (5.0.0) matches configured target version for branch (5.0.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Previously, getPacemakerStatus updated c.previous before updateOperatorStatus was called. If the status update failed, subsequent syncs would skip processing because c.previous already reflected the new CR timestamp, leaving PacemakerHealthCheckDegraded stuck a True indefinitely.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: aaece5c7-3584-4772-815e-5ad683fabcc3

📥 Commits

Reviewing files that changed from the base of the PR and between c0614ca and e897f46.

📒 Files selected for processing (2)

• pkg/tnf/pkg/pacemaker/healthcheck.go
• pkg/tnf/pkg/pacemaker/healthcheck_test.go

---

Walkthrough

The pacemaker health check controller now defers recording the previous status until after operator status updates succeed and the current status is not Unknown, instead of updating it during status retrieval. This refines when the "last valid" status baseline is established.

Changes

Pacemaker Previous Status Tracking

Layer / File(s)	Summary
Core Implementation pkg/tnf/pkg/pacemaker/healthcheck.go	The sync method defers updating c.previous to after updateOperatorStatus succeeds and only when currentStatus.OverallStatus is not Unknown, removing the prior update logic from getPacemakerStatus.
Test Alignment pkg/tnf/pkg/pacemaker/healthcheck_test.go	TestHealthCheck_getPacemakerStatus_UnchangedTimestamp now sets controller.previous = current1 after the first getPacemakerStatus call to simulate the state update that occurs during normal sync() flow, ensuring correct behavior on the second invocation.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 11 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (11 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title directly describes the main change: moving healthcheck previous state update to occur only after successful operator status update, which is the core fix in this PR.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The PR uses Go standard testing package, not Ginkgo. No Ginkgo test declarations (It, Describe, Context, When) found. All test names are static and deterministic. Check is not applicable.
Test Structure And Quality	✅ Passed	The PR modifies standard Go unit tests, not Ginkgo tests. The custom check is for Ginkgo structure (It blocks, BeforeEach), which is not applicable here.
Microshift Test Compatibility	✅ Passed	No new Ginkgo e2e tests added. PR modifies only a source file and unit tests using standard Go testing, not Ginkgo framework. Check not applicable.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	The PR modifies unit tests in pkg/tnf/pkg/pacemaker/, not e2e tests. These are standard Go tests, not Ginkgo e2e tests. The custom check only applies to Ginkgo e2e tests.
Topology-Aware Scheduling Compatibility	✅ Passed	This PR modifies only healthcheck state management logic. No scheduling constraints (affinity, node selectors, topology spread, replicas, etc.) are introduced or modified.
Ote Binary Stdout Contract	✅ Passed	PR introduces no OTE Binary Stdout Contract violations. Changes are library code using only klog.v2 for logging, with no direct stdout writes or unredirected logging.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	No Ginkgo e2e tests were added in this PR. The changes are only to standard Go unit tests (healthcheck_test.go uses testing.T, not Ginkgo patterns). Check is not applicable.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (2.12.1)

Error: can't load config: unsupported version of the configuration: "" See https://golangci-lint.run/docs/product/migration-guide for migration instructions
The command is terminated due to an error: can't load config: unsupported version of the configuration: "" See https://golangci-lint.run/docs/product/migration-guide for migration instructions

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci-robot]

@fracappa: This pull request references Jira Issue OCPBUGS-81500, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (5.0.0) matches configured target version for branch (5.0.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Details

In response to this:

Previously, getPacemakerStatus updated c.previous before updateOperatorStatus was called. If the status update failed, subsequent syncs would skip processing because c.previous already reflected the new CR timestamp, leaving PacemakerHealthCheckDegraded stuck a True indefinitely.

Summary by CodeRabbit

Bug Fixes

• Corrected Pacemaker health check status tracking to ensure accurate grace-period timing and state transitions
• Fixed handling of unknown status values during operator condition updates
• Improved reliability of health check status persistence logic

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[fonta-rh]

LGTM — the fix correctly moves c.previous assignment from getPacemakerStatus() to after updateOperatorStatus() succeeds in sync(), so a failed status write no longer poisons the skip-optimization cache.

One minor nit: the doc comment on getPacemakerStatus() (line 254) still says "For Unknown status, previous is not updated" — this referred to c.previous being written inside the function, which no longer happens for any status. Consider removing that line or replacing with something like:

// Note: c.previous is updated by sync() after successful status write, not here.

Non-blocking, cosmetic only.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fonta-rh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• pkg/tnf/OWNERS [fonta-rh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[fonta-rh]

/lgtm

[openshift-merge-bot]

Scheduling required tests:
/test e2e-agnostic-ovn
/test e2e-agnostic-ovn-upgrade
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-aws-ovn-single-node
/test e2e-gcp-operator
/test e2e-gcp-operator-disruptive
/test e2e-metal-ipi-ovn-ipv6
/test e2e-operator

[fracappa]

/retest-required

[openshift-ci]

@fracappa: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-agnostic-ovn	e897f46	link	true	/test e2e-agnostic-ovn
ci/prow/e2e-aws-ovn-single-node	e897f46	link	true	/test e2e-aws-ovn-single-node
ci/prow/e2e-aws-ovn-serial-2of2	e897f46	link	true	/test e2e-aws-ovn-serial-2of2

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.