Skip to content

OCPBUGS-43777: certrotationcontroller: run tests which runs deployment and creates projects - reapply #1831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

vrutkovs
Copy link
Member

Reverts #1830 and reapplies openshift/release#58130

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 15, 2025
@openshift-ci-robot
Copy link

@vrutkovs: This pull request references Jira Issue OCPBUGS-43777, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Reverts #1830 and reapplies openshift/release#58130

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@vrutkovs
Copy link
Member Author

/hold

until it no longer breaks nightlies

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 15, 2025
@openshift-ci openshift-ci bot requested review from deads2k and sanchezl April 15, 2025 06:20
Copy link
Contributor

openshift-ci bot commented Apr 15, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vrutkovs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 15, 2025
@vrutkovs
Copy link
Member Author

/payload 4.19 nightly blocking

Copy link
Contributor

openshift-ci bot commented Apr 15, 2025

@vrutkovs: trigger 11 job(s) of type blocking for the nightly release of OCP 4.19

  • periodic-ci-openshift-release-master-ci-4.19-e2e-aws-upgrade-ovn-single-node
  • periodic-ci-openshift-release-master-ci-4.19-e2e-aws-ovn-upgrade
  • periodic-ci-openshift-release-master-ci-4.19-e2e-azure-ovn-upgrade
  • periodic-ci-openshift-release-master-ci-4.19-upgrade-from-stable-4.18-e2e-gcp-ovn-rt-upgrade
  • periodic-ci-openshift-hypershift-release-4.19-periodics-e2e-aws-ovn-conformance
  • periodic-ci-openshift-release-master-nightly-4.19-e2e-aws-ovn-serial
  • periodic-ci-openshift-release-master-ci-4.19-e2e-aws-ovn-techpreview
  • periodic-ci-openshift-release-master-ci-4.19-e2e-aws-ovn-techpreview-serial
  • periodic-ci-openshift-release-master-nightly-4.19-fips-payload-scan
  • periodic-ci-openshift-release-master-nightly-4.19-e2e-metal-ipi-ovn-bm
  • periodic-ci-openshift-release-master-nightly-4.19-e2e-metal-ipi-ovn-ipv6

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/b375d580-19e3-11f0-9513-ecf5f407c18e-0

@vrutkovs
Copy link
Member Author

/test e2e-aws-ovn-upgrade
/payload-job periodic-ci-openshift-release-master-ci-4.19-e2e-aws-ovn-upgrade
/payload-job periodic-ci-openshift-release-master-ci-4.19-e2e-azure-ovn-upgrade

Copy link
Contributor

openshift-ci bot commented Apr 15, 2025

@vrutkovs: trigger 2 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-ci-4.19-e2e-aws-ovn-upgrade
  • periodic-ci-openshift-release-master-ci-4.19-e2e-azure-ovn-upgrade

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/0f1589b0-19ff-11f0-9818-e2d202a78a37-0

@vrutkovs
Copy link
Member Author

/retest
/payload-job periodic-ci-openshift-release-master-ci-4.19-e2e-aws-ovn-upgrade
/payload-job periodic-ci-openshift-release-master-ci-4.19-e2e-azure-ovn-upgrade

Copy link
Contributor

openshift-ci bot commented Apr 18, 2025

@vrutkovs: trigger 2 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-ci-4.19-e2e-aws-ovn-upgrade
  • periodic-ci-openshift-release-master-ci-4.19-e2e-azure-ovn-upgrade

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/defa80a0-1c47-11f0-95f3-61949f6015d1-0

@wangke19
Copy link
Contributor

/retest-required

@vrutkovs
Copy link
Member Author

/payload-job periodic-ci-openshift-release-master-ci-4.19-e2e-aws-ovn-upgrade
/payload-job periodic-ci-openshift-release-master-ci-4.19-e2e-azure-ovn-upgrade

Copy link
Contributor

openshift-ci bot commented Apr 22, 2025

@vrutkovs: trigger 2 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-ci-4.19-e2e-aws-ovn-upgrade
  • periodic-ci-openshift-release-master-ci-4.19-e2e-azure-ovn-upgrade

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/fa493550-1f4d-11f0-8c72-18a8f6900745-0

@vrutkovs
Copy link
Member Author

/retest-required

@jrvaldes
Copy link

@vrutkovs The certificate rotation test for Windows nodes has failed in recent weeks, wondering if it is related to the merge of #1759

Essentially, the Windows test forces a cert rotation by setting auth.openshift.io/certificate-not-after to null (see https://github.com/openshift/windows-machine-config-operator/blob/master/test/e2e/certificates_test.go#L58) and checks that the new cert was successfully installed in the Windows nodes.

Thoughts?

@vrutkovs
Copy link
Member Author

#1759 was quickly reverted - #1830

Essentially, the Windows test forces a cert rotation by setting auth.openshift.io/certificate-not-after to null

This is cert reissue, its different from normal cert rotation flow (both old and new signer would be included in CA if you change the annotation), so this test is valid to test emergency rotation and not representative for "normal" rotation flow. See openshift/enhancements#1670 for that

@wangke19
Copy link
Contributor

/retest-required

Copy link
Contributor

openshift-ci bot commented Apr 24, 2025

@vrutkovs: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-upgrade 47a3620 link true /test e2e-aws-ovn-upgrade
ci/prow/e2e-gcp-operator-single-node 47a3620 link false /test e2e-gcp-operator-single-node
ci/prow/okd-scos-e2e-aws-ovn 47a3620 link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-aws-ovn-single-node 47a3620 link false /test e2e-aws-ovn-single-node
ci/prow/e2e-aws-operator-disruptive-single-node 47a3620 link false /test e2e-aws-operator-disruptive-single-node
ci/prow/e2e-aws-ovn-serial 47a3620 link true /test e2e-aws-ovn-serial

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants