Skip to content

OCPNODE-3192: enable the scheduler plugin if the feature gate DynamicResourceAllocation is enabled #561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 9, 2025

Conversation

tkashem
Copy link
Contributor

@tkashem tkashem commented May 2, 2025

Use case: if the cluster admin enables TechPreview, which has DynamicResourceAllocation feature gate enabled, it should automatically enable all of DRA, including the scheduler plugin DynamicResources.

We shouldn't have to force the admin to do the extra step:

oc patch --type merge -p '{"spec":{"profile": "HighNodeUtilization", "profileCustomizations" 
{"dynamicResourceAllocation": "Enabled"}}}' scheduler cluster

@openshift-ci openshift-ci bot requested a review from ingvagabund May 2, 2025 19:39
enable the schedule plugin if the featuregate
DynamicResourceAllocation is enabled
@tkashem
Copy link
Contributor Author

tkashem commented May 2, 2025

/cc @ingvagabund

@tkashem tkashem changed the title enable the scheduler plugin if the featuregate DynamicResourceAllocation is enabled enable the scheduler plugin if the feature gate DynamicResourceAllocation is enabled May 2, 2025
@rphillips
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 2, 2025
Copy link
Contributor

openshift-ci bot commented May 2, 2025

@tkashem: This PR was included in a payload test run from openshift/kubernetes#2273
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-ci-4.19-e2e-gcp-ovn

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/0f772e30-2793-11f0-8fbe-c94db7af584d-0

Copy link
Contributor

openshift-ci bot commented May 4, 2025

@tkashem: This PR was included in a payload test run from openshift/kubernetes#2273
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-ci-4.19-e2e-gcp-ovn

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/beeeb4a0-288d-11f0-8fa5-4c3afe80160d-0

@ingvagabund
Copy link
Member

/approve

Copy link
Contributor

openshift-ci bot commented May 4, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ingvagabund, rphillips, tkashem

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 4, 2025
@ingvagabund
Copy link
Member

@tkashem let's wait for the branching. Unless this is needed in 4.19 as well.
/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 4, 2025
@ingvagabund
Copy link
Member

/retest-required

Copy link
Contributor

openshift-ci bot commented May 4, 2025

@tkashem: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@tkashem
Copy link
Contributor Author

tkashem commented May 5, 2025

@tkashem let's wait for the branching. Unless this is needed in 4.19 as well.

+1 (it's not strictly required for 4.19)

@ingvagabund
Copy link
Member

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 7, 2025
@tkashem
Copy link
Contributor Author

tkashem commented May 7, 2025

/hold

(let's wait for CR to be little bit more stable)

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 7, 2025
@tkashem tkashem changed the title enable the scheduler plugin if the feature gate DynamicResourceAllocation is enabled OCPNODE-3192: enable the scheduler plugin if the feature gate DynamicResourceAllocation is enabled May 7, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 7, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 7, 2025

@tkashem: This pull request references OCPNODE-3192 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.20.0" version, but no target version was set.

In response to this:

Use case: if the cluster admin enables TechPreview, which has DynamicResourceAllocation feature gate enabled, it should automatically enable all of DRA, including the scheduler plugin DynamicResources.

We shouldn't have to force the admin to do the extra step:

oc patch --type merge -p '{"spec":{"profile": "HighNodeUtilization", "profileCustomizations" 
{"dynamicResourceAllocation": "Enabled"}}}' scheduler cluster

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@tkashem
Copy link
Contributor Author

tkashem commented May 9, 2025

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 9, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 0d060e4 into openshift:master May 9, 2025
12 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ose-cluster-kube-scheduler-operator
This PR has been included in build ose-cluster-kube-scheduler-operator-container-v4.20.0-202505091411.p0.g0d060e4.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants