-
Notifications
You must be signed in to change notification settings - Fork 80
OCPNODE-3192: enable the scheduler plugin if the feature gate DynamicResourceAllocation is enabled #561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
enable the schedule plugin if the featuregate DynamicResourceAllocation is enabled
/cc @ingvagabund |
/lgtm |
@tkashem: This PR was included in a payload test run from openshift/kubernetes#2273
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/0f772e30-2793-11f0-8fbe-c94db7af584d-0 |
@tkashem: This PR was included in a payload test run from openshift/kubernetes#2273
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/beeeb4a0-288d-11f0-8fa5-4c3afe80160d-0 |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ingvagabund, rphillips, tkashem The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@tkashem let's wait for the branching. Unless this is needed in 4.19 as well. |
/retest-required |
@tkashem: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
+1 (it's not strictly required for 4.19) |
/hold cancel |
/hold (let's wait for CR to be little bit more stable) |
@tkashem: This pull request references OCPNODE-3192 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.20.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/hold cancel |
[ART PR BUILD NOTIFIER] Distgit: ose-cluster-kube-scheduler-operator |
Use case: if the cluster admin enables
TechPreview
, which hasDynamicResourceAllocation
feature gate enabled, it should automatically enable all of DRA, including the scheduler pluginDynamicResources
.We shouldn't have to force the admin to do the extra step: