Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-6.2]LOG-6878: fix validation rule for Loki Tuning to allow it to be empty without failing validation #2989

Merged
merged 1 commit into from
Mar 28, 2025

Conversation

vparfonov
Copy link
Contributor

@vparfonov vparfonov commented Mar 17, 2025

Description

back-port #2956

/cc
/assign

/cherry-pick

Links

… without failing validation Signed-off-by: Vitalii Parfonov <[email protected]>
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 17, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 17, 2025

@vparfonov: This pull request references LOG-6878 which is a valid jira issue.

In response to this:

Description

/cc
/assign

/cherry-pick

Links

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@vparfonov
Copy link
Contributor Author

/assign @jcantrill

@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 17, 2025

@vparfonov: This pull request references LOG-6878 which is a valid jira issue.

In response to this:

Description

back-port #2956

/cc
/assign

/cherry-pick

Links

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@vparfonov vparfonov changed the title LOG-6878: fix validation rule for Loki Tuning to allow it to be empty without failing validation [release-6.2]LOG-6878: fix validation rule for Loki Tuning to allow it to be empty without failing validation Mar 17, 2025
@vparfonov
Copy link
Contributor Author

/test e2e-target

Copy link
Contributor

openshift-ci bot commented Mar 17, 2025

@vparfonov: No presubmit jobs available for openshift/[email protected]

In response to this:

/test e2e-target

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jcantrill
Copy link
Contributor

/retest
/approve

Copy link
Contributor

openshift-ci bot commented Mar 18, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcantrill, vparfonov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 18, 2025
@vparfonov
Copy link
Contributor Author

/test e2e-target

@Clee2691
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 28, 2025
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD bcc5421 and 2 for PR HEAD e6b8909 in total

Copy link
Contributor

openshift-ci bot commented Mar 28, 2025

@vparfonov: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit ccac63a into openshift:release-6.2 Mar 28, 2025
8 checks passed
@openshift-cherrypick-robot

@vparfonov: cannot checkout <!--: error checking out "<!--": exit status 1 error: pathspec '<!--' did not match any file(s) known to git

In response to this:

Description

back-port #2956

/cc
/assign

/cherry-pick

Links

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. release/6.2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants