Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LOG-6723: Update golang to v1.23 #3000

Merged
merged 1 commit into from
Mar 28, 2025
Merged

LOG-6723: Update golang to v1.23 #3000

merged 1 commit into from
Mar 28, 2025

Conversation

jcantrill
Copy link
Contributor

Description

This PR

  • updates the golang builder for development builds.
  • unblocks updated CI which keeps reverting changes

Links

https://issues.redhat.com/browse/LOG-6723

cc @vparfonov @cahartma @Clee2691

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 27, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 27, 2025 •
edited by openshift-ci bot
Loading

@jcantrill: This pull request references LOG-6723 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.8.0" version, but no target version was set.

In response to this:

Description

This PR

  • updates the golang builder for development builds.
  • unblocks updated CI which keeps reverting changes

Links

https://issues.redhat.com/browse/LOG-6723

cc @vparfonov @cahartma @Clee2691

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jcantrill jcantrill added release/6.3 and removed jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels Mar 27, 2025
@openshift-ci openshift-ci bot requested review from alanconway and cahartma March 27, 2025 13:06
@openshift-ci openshift-ci bot added the midstream/Dockerfile A Dockerfile.in sync is needed with midstream label Mar 27, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 27, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcantrill

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 27, 2025
@cahartma
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 27, 2025
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 27, 2025
@vparfonov
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 27, 2025
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 6a031bd and 2 for PR HEAD 1198a62 in total

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 27, 2025
@jcantrill
Copy link
Contributor Author

/test images

3 similar comments
@jcantrill
Copy link
Contributor Author

/test images

@jcantrill
Copy link
Contributor Author

/test images

@jcantrill
Copy link
Contributor Author

/test images

@jcantrill
Copy link
Contributor Author

/retest

vparfonov
vparfonov reviewed Mar 28, 2025
View reviewed changes
olm_deploy/operatorregistry/Dockerfile Outdated

FROM registry.access.redhat.com/ubi9/ubi-minimal
USER 0
RUN micro dnf install gettext -y
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
RUN micro dnf install gettext -y
RUN microdnf install gettext -y

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jcantrill ^^

@vparfonov
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 28, 2025
@jcantrill
Copy link
Contributor Author

/test e2e-target

@jcantrill
Copy link
Contributor Author

/override ci/prow/e2e-target

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 28, 2025

@jcantrill: Overrode contexts on behalf of jcantrill: ci/prow/e2e-target

In response to this:

/override ci/prow/e2e-target

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 28, 2025

@jcantrill: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit db1f385 into openshift:master Mar 28, 2025
8 checks passed
@jcantrill jcantrill deleted the log6723 branch March 28, 2025 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vparfonov vparfonov vparfonov left review comments

@alanconway alanconway Awaiting requested review from alanconway

@cahartma cahartma Awaiting requested review from cahartma

Assignees

@vparfonov vparfonov

@cahartma cahartma

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. midstream/Dockerfile A Dockerfile.in sync is needed with midstream release/6.3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jcantrill @openshift-ci-robot @cahartma @vparfonov