Skip to content

CNTRLPLANE-341: Issue shorter certificates when ShortRotation featuregate is enabled #2556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

CNTRLPLANE-341: Issue shorter certificates when ShortRotation featuregate is enabled #2556

wants to merge 1 commit into from

Conversation

vrutkovs
Copy link
Member

@vrutkovs vrutkovs commented Nov 7, 2024 •
edited
Loading

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 7, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 7, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@vrutkovs vrutkovs force-pushed the short-cert-rotation-featuregate branch 2 times, most recently from c8a572c to 7e10721 Compare November 7, 2024 13:28
@vrutkovs vrutkovs force-pushed the short-cert-rotation-featuregate branch from d268d10 to 7e10721 Compare November 15, 2024 11:42
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 20, 2024
@vrutkovs vrutkovs force-pushed the short-cert-rotation-featuregate branch from a90577c to 7d18b43 Compare March 17, 2025 10:11
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 17, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 17, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: vrutkovs
Once this PR has been reviewed and has the lgtm label, please assign dougbtv for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vrutkovs vrutkovs marked this pull request as ready for review March 17, 2025 10:20
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 17, 2025
@openshift-ci openshift-ci bot requested review from dougbtv and kyrtapz March 17, 2025 10:25
@vrutkovs vrutkovs changed the title Issue shorter certificates when ShortRotation featuregate is enabled CNTRLPLANE-341: Issue shorter certificates when ShortRotation featuregate is enabled Mar 19, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 19, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 19, 2025 •
edited by openshift-ci bot
Loading

@vrutkovs: This pull request references CNTRLPLANE-341 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.19.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@vrutkovs vrutkovs force-pushed the short-cert-rotation-featuregate branch 2 times, most recently from 39eb9ce to 6765791 Compare March 19, 2025 11:59
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 19, 2025 •
edited by openshift-ci bot
Loading

@vrutkovs: This pull request references CNTRLPLANE-341 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.19.0" version, but no target version was set.

In response to this:

Depends on #2656

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@vrutkovs vrutkovs force-pushed the short-cert-rotation-featuregate branch from 6765791 to a21b038 Compare April 3, 2025 13:25
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 3, 2025 •
edited by openshift-ci bot
Loading

@vrutkovs: This pull request references CNTRLPLANE-341 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.19.0" version, but no target version was set.

In response to this:

Implements openshift/enhancements#1670

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@vrutkovs vrutkovs force-pushed the short-cert-rotation-featuregate branch from a21b038 to 76ff3c2 Compare April 10, 2025 11:04
@vrutkovs vrutkovs force-pushed the short-cert-rotation-featuregate branch from 76ff3c2 to fe17d40 Compare April 24, 2025 07:32
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 24, 2025

@vrutkovs: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-serial fe17d40 link false /test e2e-aws-ovn-serial
ci/prow/e2e-aws-ovn-windows fe17d40 link true /test e2e-aws-ovn-windows
ci/prow/e2e-aws-hypershift-ovn-kubevirt fe17d40 link false /test e2e-aws-hypershift-ovn-kubevirt
ci/prow/e2e-aws-ovn-ipsec-upgrade fe17d40 link true /test e2e-aws-ovn-ipsec-upgrade
ci/prow/4.19-upgrade-from-stable-4.18-e2e-azure-ovn-upgrade fe17d40 link false /test 4.19-upgrade-from-stable-4.18-e2e-azure-ovn-upgrade
ci/prow/e2e-vsphere-ovn-dualstack-primaryv6 fe17d40 link false /test e2e-vsphere-ovn-dualstack-primaryv6
ci/prow/4.19-upgrade-from-stable-4.18-e2e-gcp-ovn-upgrade fe17d40 link false /test 4.19-upgrade-from-stable-4.18-e2e-gcp-ovn-upgrade
ci/prow/security fe17d40 link false /test security
ci/prow/4.19-upgrade-from-stable-4.18-e2e-aws-ovn-upgrade fe17d40 link false /test 4.19-upgrade-from-stable-4.18-e2e-aws-ovn-upgrade
ci/prow/e2e-metal-ipi-ovn-ipv6-ipsec fe17d40 link true /test e2e-metal-ipi-ovn-ipv6-ipsec
ci/prow/e2e-metal-ipi-ovn-ipv6 fe17d40 link true /test e2e-metal-ipi-ovn-ipv6

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dougbtv dougbtv Awaiting requested review from dougbtv

@kyrtapz kyrtapz Awaiting requested review from kyrtapz

Assignees
No one assigned
Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vrutkovs @openshift-ci-robot @openshift-merge-robot