Skip to content

[DNM] Use correct regex for IPv6 IPsec connections #2693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pperiyasamy
Copy link
Member

No description provided.

Signed-off-by: Periyasamy Palanisamy <[email protected]>
@openshift-ci openshift-ci bot requested review from danwinship and tssurya April 23, 2025 19:26
Copy link
Contributor

openshift-ci bot commented Apr 23, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: pperiyasamy
Once this PR has been reviewed and has the lgtm label, please assign abhat for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pperiyasamy
Copy link
Member Author

/retest

@pperiyasamy
Copy link
Member Author

The fix is in effect, e2e-metal-ipi-ovn-ipv6-ipsec run failed because of job timeout, so we must get openshift/release#64174 also landed.

@pperiyasamy pperiyasamy changed the title [DNM] Use correct regex for IPv6 IPsec connections Use correct regex for IPv6 IPsec connections Apr 24, 2025
@pperiyasamy
Copy link
Member Author

/test e2e-aws-ovn-ipsec-upgrade

@pperiyasamy
Copy link
Member Author

/assign @igsilya @kyrtapz @tssurya

@kyrtapz
Copy link
Contributor

kyrtapz commented Apr 24, 2025

@pperiyasamy is this a workaround? Please add a comment to the code and a description of the issue to the PR/commit.
If there is an issue with the script is it tracked as a bug somewhere?

@igsilya
Copy link

igsilya commented Apr 24, 2025

IMO, this code should not be merged. It is a good test to verify the fix, but the fix should be shipped in the OVS package instead.
/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 24, 2025
@pperiyasamy pperiyasamy changed the title Use correct regex for IPv6 IPsec connections [DNM] Use correct regex for IPv6 IPsec connections Apr 24, 2025
@pperiyasamy
Copy link
Member Author

@pperiyasamy is this a workaround? Please add a comment to the code and a description of the issue to the PR/commit. If there is an issue with the script is it tracked as a bug somewhere?

@kyrtapz please ignore this PR for the review, it's just for testing.

Copy link
Contributor

openshift-ci bot commented Apr 24, 2025

@pperiyasamy: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-windows a8cb37f link true /test e2e-aws-ovn-windows
ci/prow/e2e-aws-hypershift-ovn-kubevirt a8cb37f link false /test e2e-aws-hypershift-ovn-kubevirt
ci/prow/4.19-upgrade-from-stable-4.18-e2e-aws-ovn-upgrade a8cb37f link false /test 4.19-upgrade-from-stable-4.18-e2e-aws-ovn-upgrade
ci/prow/4.19-upgrade-from-stable-4.18-e2e-azure-ovn-upgrade a8cb37f link false /test 4.19-upgrade-from-stable-4.18-e2e-azure-ovn-upgrade
ci/prow/e2e-ovn-ipsec-step-registry a8cb37f link true /test e2e-ovn-ipsec-step-registry
ci/prow/e2e-vsphere-ovn-dualstack-primaryv6 a8cb37f link false /test e2e-vsphere-ovn-dualstack-primaryv6
ci/prow/e2e-aws-ovn-ipsec-upgrade a8cb37f link true /test e2e-aws-ovn-ipsec-upgrade
ci/prow/security a8cb37f link false /test security
ci/prow/e2e-aws-ovn-serial a8cb37f link false /test e2e-aws-ovn-serial

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants