OCPBUGS-55763: stop frr from listening for incoming connection in the bgp daemon #2708
Conversation
frr-k8s will not listen to port 179, and BGP peering can only be established from OCP to external. Signed-off-by: Konstantinos Karampogias <[email protected]>
|
cc @fedepaol |
|
@karampok I think this deserves do be a bug as we did it non - intentionally (the behavior was reverted upstream and on metallb itself). |
Also, we might need to backport it at least to 4.19 |
karampok
changed the title
karampok
changed the title
|
/jira refresh |
|
@karampok: No Jira issue is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
The frr-k8s fail with which is known issue |
|
/jira refresh |
|
@karampok: No Jira issue is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retest frrk8s-e2e |
|
@karampok: The The following commands are available to trigger optional jobs: Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test frrk8s-e2e |
karampok
changed the title
openshift-ci-robot
added
jira/severity-important
|
@karampok: This pull request references Jira Issue OCPBUGS-55763, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
|
@karampok: This pull request references Jira Issue OCPBUGS-55763, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
openshift-ci-robot
added
jira/valid-bug
|
@karampok: This pull request references Jira Issue OCPBUGS-55763, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retest-required |
|
@karampok: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/retest-required |
|
/hold |
|
/lgtm |
openshift-ci
bot
added
the
do-not-merge/hold
|
@karampok please un - hold when we manage to get a green frrk8s run (iiuc, it's failing due to external factors, which should sort out hopefully) |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fedepaol, karampok The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
By design, the bgp daemon running by frr should be the active part in the BGP peering.
That means that it is not listening at port 179 for incoming TCP connection from external peers.
To achieve that we need to modify the params provided by a configmap in the frr pods accordingly.
The documentation part
This PR aligns that behavior.